[GitHub] [geode] bschuchardt opened a new pull request #6314: GEODE-9141: Hang while shutting down a cache server due to corrupted message

[GitBox <gi...@apache.org>]

bschuchardt opened a new pull request #6314:
URL: https://github.com/apache/geode/pull/6314


   The corruption is occurring because another thread was using it to
   perform a handshake on a new Connection and was still in
   SocketChannel.read().  The thread initiating the handshake was
   interrupted by CacheServer.close() and released the buffer prematurely,
   allowing another thread to grab the still in-use buffer and serialize
   a message into it.  The handshake thread's SocketChannel.read()
   overwrites some of the content of the buffer before it is transmitted.
   
   The fix is to include the input buffer as state that needs to be
   protected by the stateLock and allow the handshake thread to retain
   ownership of the buffer, releasing it in it's cleanup code.
   
   I also deleted some very old checks for an IBM JRE that is no longer
   required and was interfering with efforts to write a unit test.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] bschuchardt closed pull request #6314: GEODE-9141: Hang while shutting down a cache server due to corrupted message

[GitBox <gi...@apache.org>]

bschuchardt closed pull request #6314:
URL: https://github.com/apache/geode/pull/6314


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill commented on a change in pull request #6314: GEODE-9141: Hang while shutting down a cache server due to corrupted message

[GitBox <gi...@apache.org>]

Bill commented on a change in pull request #6314:
URL: https://github.com/apache/geode/pull/6314#discussion_r613425272



##########
File path: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##########
@@ -1938,6 +1942,10 @@ public void setInUse(boolean use, long startTime, long ackWaitThreshold, long ac
     }
   }
 
+  void setReaderThreadForTest(Thread threadForTest) {

Review comment:
       add `@VisibleForTesting`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org