You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/01 08:42:22 UTC

[GitHub] [iotdb] CloudWise-Lukemiao opened a new pull request #3299: iotdb add openapi moudle

CloudWise-Lukemiao opened a new pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299


   The open API module supports HTTP and HTTPS, including grafana interface, Prometheus interface, read data interface, write data interface and non query interface


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] sonarcloud[bot] commented on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-852051970


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls commented on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/40196084/badge)](https://coveralls.io/builds/40196084)
   
   Coverage increased (+0.1%) to 68.042% when pulling **8119ce1c1475e8e0d813079a066fbeff0f41fe7c on CloudWise-Lukemiao:dev-openapi** into **622a9c412e51d45b28325ebf0b3d89b22ef7aaae on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/40196319/badge)](https://coveralls.io/builds/40196319)
   
   Coverage increased (+0.1%) to 68.039% when pulling **8119ce1c1475e8e0d813079a066fbeff0f41fe7c on CloudWise-Lukemiao:dev-openapi** into **622a9c412e51d45b28325ebf0b3d89b22ef7aaae on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41597297/badge)](https://coveralls.io/builds/41597297)
   
   Coverage decreased (-0.07%) to 68.101% when pulling **8d32a2748d5931fdf4c4f75c5679e99ca1d9ac41 on CloudWise-Lukemiao:dev-openapi** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41678281/badge)](https://coveralls.io/builds/41678281)
   
   Coverage increased (+0.02%) to 68.09% when pulling **9fce7b9911b8b305cd84ed73f82c136d679cef1b on CloudWise-Lukemiao:dev-openapi** into **47fa594403d5bb0c79d8414886b5a9fe6a24b778 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851985500


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou commented on a change in pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#discussion_r656898170



##########
File path: server/src/test/java/org/apache/iotdb/openapi/apache/iotdb/OpenApiServiceTest.java
##########
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.openapi.apache.iotdb;
+
+import org.apache.iotdb.db.utils.EnvironmentUtils;
+import org.apache.iotdb.openapi.gen.handler.NotFoundException;
+import org.apache.iotdb.openapi.gen.handler.filter.BasicSecurityContext;
+import org.apache.iotdb.openapi.gen.handler.impl.V1ApiServiceImpl;
+import org.apache.iotdb.openapi.gen.handler.model.User;
+import org.apache.iotdb.openapi.gen.model.GroupByFillPlan;
+import org.apache.iotdb.openapi.gen.model.ReadData;
+import org.apache.iotdb.openapi.gen.model.WriteData;
+
+import com.google.gson.Gson;
+import org.junit.Before;

Review comment:
       ```suggestion
   import com.google.gson.Gson;
   import org.junit.After;
   import org.junit.Before;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41681900/badge)](https://coveralls.io/builds/41681900)
   
   Coverage increased (+0.06%) to 68.129% when pulling **547746c476f385cbe7e0eb5ace1a7e72527ce3ef on CloudWise-Lukemiao:dev-openapi** into **47fa594403d5bb0c79d8414886b5a9fe6a24b778 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41676927/badge)](https://coveralls.io/builds/41676927)
   
   Coverage increased (+0.001%) to 68.07% when pulling **9fce7b9911b8b305cd84ed73f82c136d679cef1b on CloudWise-Lukemiao:dev-openapi** into **47fa594403d5bb0c79d8414886b5a9fe6a24b778 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou commented on a change in pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#discussion_r656872358



##########
File path: server/src/test/java/org/apache/iotdb/openapi/apache/iotdb/OpenApiServiceTest.java
##########
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.openapi.apache.iotdb;
+
+import org.apache.iotdb.db.utils.EnvironmentUtils;
+import org.apache.iotdb.openapi.gen.handler.NotFoundException;
+import org.apache.iotdb.openapi.gen.handler.filter.BasicSecurityContext;
+import org.apache.iotdb.openapi.gen.handler.impl.V1ApiServiceImpl;
+import org.apache.iotdb.openapi.gen.handler.model.User;
+import org.apache.iotdb.openapi.gen.model.GroupByFillPlan;
+import org.apache.iotdb.openapi.gen.model.ReadData;
+import org.apache.iotdb.openapi.gen.model.WriteData;
+
+import com.google.gson.Gson;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.ws.rs.core.Response;
+
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class OpenApiServiceTest {
+  GroupByFillPlan groupByFillPlan = new GroupByFillPlan();
+  User user = new User();
+  BasicSecurityContext basicSecurityContext = new BasicSecurityContext(user, false);
+  V1ApiServiceImpl v1ApiService = new V1ApiServiceImpl();
+
+  @Before
+  public void setUp() {
+    EnvironmentUtils.envSetUp();
+    user.setUsername("root");
+    user.setPassword("root");
+    BigDecimal stime = BigDecimal.valueOf(1);
+    BigDecimal etime = BigDecimal.valueOf(10);
+    List<String> path = new ArrayList<String>();
+    path.add("root");
+    path.add("sg");
+    path.add("aa");
+    groupByFillPlan.setStime(stime);
+    groupByFillPlan.setEtime(etime);
+    groupByFillPlan.setPaths(path);
+    groupByFillPlan.setInterval("1ms");
+  }
+

Review comment:
       ```suggestion
   
     @After
     public void tearDown() throws Exception {
       EnvironmentUtils.cleanEnv();
     }
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41601823/badge)](https://coveralls.io/builds/41601823)
   
   Coverage decreased (-0.07%) to 68.104% when pulling **cb3e133b2697b7295d4cdf30e8a5e3f1722b0191 on CloudWise-Lukemiao:dev-openapi** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41597325/badge)](https://coveralls.io/builds/41597325)
   
   Coverage decreased (-0.09%) to 68.089% when pulling **8d32a2748d5931fdf4c4f75c5679e99ca1d9ac41 on CloudWise-Lukemiao:dev-openapi** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41348675/badge)](https://coveralls.io/builds/41348675)
   
   Coverage decreased (-0.04%) to 68.137% when pulling **c6f77d9485ac059b5aff842a7047dc78438fd6b1 on CloudWise-Lukemiao:dev-openapi** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41706913/badge)](https://coveralls.io/builds/41706913)
   
   Coverage increased (+0.1%) to 68.207% when pulling **1d4d795f001bc79a283120cf9addf90afc848cf3 on CloudWise-Lukemiao:dev-openapi** into **47fa594403d5bb0c79d8414886b5a9fe6a24b778 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/40350862/badge)](https://coveralls.io/builds/40350862)
   
   Coverage decreased (-0.04%) to 67.883% when pulling **227645dd22d746c8f8f0a50e5bfe687849b186fc on CloudWise-Lukemiao:dev-openapi** into **16167373d924b4f457ce380144a2564be76b65b2 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/40199487/badge)](https://coveralls.io/builds/40199487)
   
   Coverage decreased (-0.02%) to 67.882% when pulling **cc5ddc35056169bcb67de9465fb534960250940f on CloudWise-Lukemiao:dev-openapi** into **622a9c412e51d45b28325ebf0b3d89b22ef7aaae on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou commented on a change in pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#discussion_r656872358



##########
File path: server/src/test/java/org/apache/iotdb/openapi/apache/iotdb/OpenApiServiceTest.java
##########
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.openapi.apache.iotdb;
+
+import org.apache.iotdb.db.utils.EnvironmentUtils;
+import org.apache.iotdb.openapi.gen.handler.NotFoundException;
+import org.apache.iotdb.openapi.gen.handler.filter.BasicSecurityContext;
+import org.apache.iotdb.openapi.gen.handler.impl.V1ApiServiceImpl;
+import org.apache.iotdb.openapi.gen.handler.model.User;
+import org.apache.iotdb.openapi.gen.model.GroupByFillPlan;
+import org.apache.iotdb.openapi.gen.model.ReadData;
+import org.apache.iotdb.openapi.gen.model.WriteData;
+
+import com.google.gson.Gson;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.ws.rs.core.Response;
+
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class OpenApiServiceTest {
+  GroupByFillPlan groupByFillPlan = new GroupByFillPlan();
+  User user = new User();
+  BasicSecurityContext basicSecurityContext = new BasicSecurityContext(user, false);
+  V1ApiServiceImpl v1ApiService = new V1ApiServiceImpl();
+
+  @Before
+  public void setUp() {
+    EnvironmentUtils.envSetUp();
+    user.setUsername("root");
+    user.setPassword("root");
+    BigDecimal stime = BigDecimal.valueOf(1);
+    BigDecimal etime = BigDecimal.valueOf(10);
+    List<String> path = new ArrayList<String>();
+    path.add("root");
+    path.add("sg");
+    path.add("aa");
+    groupByFillPlan.setStime(stime);
+    groupByFillPlan.setEtime(etime);
+    groupByFillPlan.setPaths(path);
+    groupByFillPlan.setInterval("1ms");
+  }
+

Review comment:
       Add a tearDown method?
   ```suggestion
   
     @After
     public void tearDown() throws Exception {
       EnvironmentUtils.cleanEnv();
     }
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981015


   
   [![Coverage Status](https://coveralls.io/builds/41677850/badge)](https://coveralls.io/builds/41677850)
   
   Coverage increased (+0.02%) to 68.092% when pulling **9fce7b9911b8b305cd84ed73f82c136d679cef1b on CloudWise-Lukemiao:dev-openapi** into **47fa594403d5bb0c79d8414886b5a9fe6a24b778 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] sonarcloud[bot] commented on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981895


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851981895


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] CloudWise-Lukemiao closed pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
CloudWise-Lukemiao closed pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] sonarcloud[bot] commented on pull request #3299: iotdb add openapi moudle

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3299:
URL: https://github.com/apache/iotdb/pull/3299#issuecomment-851985500


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=3299&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=3299&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org