You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/04/03 22:03:46 UTC
[kudu-CR] Followup to fe4d962c09012e to fix broken test
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9917
to review the following change.
Change subject: Followup to fe4d962c09012e to fix broken test
......................................................................
Followup to fe4d962c09012e to fix broken test
The newly introduced tests weren't cleaning up the test directory
beccause they didn't inherit from KuduTest.
Change-Id: I0e323f5c9082013510cddc6873bd81675e66d644
---
M src/kudu/hms/hms_catalog-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/9917/1
--
To view, visit http://gerrit.cloudera.org:8080/9917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e323f5c9082013510cddc6873bd81675e66d644
Gerrit-Change-Number: 9917
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Followup to fe4d962c09012e to fix broken test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9917 )
Change subject: Followup to fe4d962c09012e to fix broken test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e323f5c9082013510cddc6873bd81675e66d644
Gerrit-Change-Number: 9917
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:32:11 +0000
Gerrit-HasComments: No
[kudu-CR] Followup to fe4d962c09012e to fix broken test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9917 )
Change subject: Followup to fe4d962c09012e to fix broken test
......................................................................
Followup to fe4d962c09012e to fix broken test
The newly introduced tests weren't cleaning up the test directory
because they didn't inherit from KuduTest.
Change-Id: I0e323f5c9082013510cddc6873bd81675e66d644
Reviewed-on: http://gerrit.cloudera.org:8080/9917
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/hms/hms_catalog-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e323f5c9082013510cddc6873bd81675e66d644
Gerrit-Change-Number: 9917
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Followup to fe4d962c09012e to fix broken test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9917 )
Change subject: Followup to fe4d962c09012e to fix broken test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9917/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9917/1//COMMIT_MSG@10
PS1, Line 10: beccause
because
--
To view, visit http://gerrit.cloudera.org:8080/9917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e323f5c9082013510cddc6873bd81675e66d644
Gerrit-Change-Number: 9917
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 03 Apr 2018 22:06:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] Followup to fe4d962c09012e to fix broken test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9917
to look at the new patch set (#2).
Change subject: Followup to fe4d962c09012e to fix broken test
......................................................................
Followup to fe4d962c09012e to fix broken test
The newly introduced tests weren't cleaning up the test directory
because they didn't inherit from KuduTest.
Change-Id: I0e323f5c9082013510cddc6873bd81675e66d644
---
M src/kudu/hms/hms_catalog-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/9917/2
--
To view, visit http://gerrit.cloudera.org:8080/9917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e323f5c9082013510cddc6873bd81675e66d644
Gerrit-Change-Number: 9917
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins