You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/06/27 08:19:53 UTC

[GitHub] [airflow] eladkal opened a new pull request, #32172: Revert "add deferrable mode for `AthenaOperator`"

eladkal opened a new pull request, #32172:
URL: https://github.com/apache/airflow/pull/32172

   Reverts apache/airflow#32110
   
   Fix failing main:
   ```
   
   =========================== short test summary info ============================
   FAILED tests/providers/amazon/aws/hooks/test_rds.py::TestRdsHook::test_wait_for_db_instance_state_boto_waiters - AssertionError: expected call not found.
   Expected: wait(DBInstanceIdentifier='testrdshook-db-instance', WaiterConfig={'Delay': 0, 'MaxAttempts': 1})
   Actual: wait(DBInstanceIdentifier='testrdshook-db-instance', WaiterConfig={'MaxAttempts': 1})
   
   pytest introspection follows:
   
   Kwargs:
   assert {'DBInstanceI...Attempts': 1}} == {'DBInstanceI...Attempts': 1}}
     Omitting 1 identical items, use -vv to show
     Differing items:
     {'WaiterConfig': {'MaxAttempts': 1}} != {'WaiterConfig': {'Delay': 0, 'MaxAttempts': 1}}
     Full diff:
       {
        'DBInstanceIdentifier': 'testrdshook-db-instance',
     -  'WaiterConfig': {'Delay': 0, 'MaxAttempts': 1},
     ?                   ------------
     +  'WaiterConfig': {'MaxAttempts': 1},
       }
   FAILED tests/providers/amazon/aws/triggers/test_athena.py::TestAthenaTrigger::test_run_success - TypeError: async_wait() got an unexpected keyword argument 'max_attempts'
   ```
   
   
   Examples:
   https://github.com/apache/airflow/actions/runs/5386754572/jobs/9777311585?pr=32171#step:6:4846
   https://github.com/apache/airflow/actions/runs/5386754572/jobs/9777311585?pr=32171#step:6:4880


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #32172: Revert "add deferrable mode for `AthenaOperator`"

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32172:
URL: https://github.com/apache/airflow/pull/32172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org