You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/08/04 15:41:14 UTC
[GitHub] [lucene-solr] HoustonPutman opened a new pull request #1716: SOLR-14706: Fix support for default autoscaling policy
HoustonPutman opened a new pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716
https://issues.apache.org/jira/browse/SOLR-14706
This is to introduce backwards compatibility for the default autoscaling policy that was removed in 8.6.1 (and 8.7).
The upgrade notes now include the steps to remove the default autoscaling policy via the autoscaling API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465875461
##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -34,17 +34,24 @@ Detailed steps for upgrading a Solr cluster are in the section <<upgrading-a-sol
If you are upgrading from 7.x, see the section <<Upgrading from 7.x Releases>> below.
-=== Solr 8.6.1
+=== Solr 8.6.1 (Upgrading from 8.6.0 only)
*Autoscaling*
* As mentioned in the 8.6 upgrade notes, a default autoscaling policy was provided starting in 8.6.0.
This default autoscaling policy resulted in increasingly slow collection creation calls in large clusters (50+ collections).
+
In 8.6.1 the default autoscaling policy has been removed, and clouds will not use autoscaling unless a policy has explicitly been created.
-In order to fix the performance degradations introduced in 8.6.0, merely upgrade to 8.6.1.
+If your cloud has been upgraded to 8.6.0 and you wish to fix this performance degredations, upgrade to 8.6.1 and remove the default cluster policy via the following command.
+Replace `localhost:8983` with your Solr endpoint.
++
+```
+curl -X POST -H 'Content-type:application/json' -d '{set-cluster-policy : []}' http://localhost:8983/api/cluster/autoscaling
Review comment:
Yeah that looks better :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r466643442
##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -34,17 +34,29 @@ Detailed steps for upgrading a Solr cluster are in the section <<upgrading-a-sol
If you are upgrading from 7.x, see the section <<Upgrading from 7.x Releases>> below.
-=== Solr 8.6.1
+=== Solr 8.6.1 (Upgrading from 8.6.0 only)
+
+See the https://cwiki.apache.org/confluence/display/SOLR/ReleaseNote861[8.6.1 Release Notes^]
+for an overview of the fixes included in Solr 8.6.1.
+
+When upgrading to 8.6.1 users should be aware of the following major changes from 8.6.0.
*Autoscaling*
* As mentioned in the 8.6 upgrade notes, a default autoscaling policy was provided starting in 8.6.0.
This default autoscaling policy resulted in increasingly slow collection creation calls in large clusters (50+ collections).
+
In 8.6.1 the default autoscaling policy has been removed, and clouds will not use autoscaling unless a policy has explicitly been created.
-In order to fix the performance degradations introduced in 8.6.0, merely upgrade to 8.6.1.
+If your cloud is running 8.6.0 and **not using an explicit autoscaling policy**, upgrade to 8.6.1 and remove the default cluster policy and preferences via the following command.
+Replace `localhost:8983` with your Solr endpoint.
++
+```
+curl -X POST -H 'Content-type:application/json' -d '{set-cluster-policy : [], set-cluster-preferences : []}' http://localhost:8983/api/cluster/autoscaling
Review comment:
Hmmm, I'm a bit confused about that. So if I spin up a new cloud with 8.5, I don't see a `cluster-preferences`. It basically looks the same as a 8.6.1 cloud that has the above command run. So if we reverted the change of the defaulting patch, shouldn't a 8.5 cloud and 8.6.1 cloud with identical `autoscaling.json` ZNodes behave the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] sigram commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
sigram commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r466605349
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Clause.java
##########
@@ -117,10 +117,10 @@ private Clause(Map<String, Object> m) {
strict = Boolean.parseBoolean(String.valueOf(m.getOrDefault("strict", "true")));
Optional<String> globalTagName = m.keySet().stream().filter(Policy.GLOBAL_ONLY_TAGS::contains).findFirst();
if (globalTagName.isPresent()) {
- globalTag = parse(globalTagName.get(), m);
- if (m.size() > 2) {
- throw new RuntimeException("Only one extra tag supported for the tag " + globalTagName.get() + " in " + toJSONString(m));
+ if (m.size() > 3) {
Review comment:
@gus-asf yes, that's the intent, though your pseudo-code is still incorrect - if there's no `strict` tag then `m.size() > 2` is already an error. In other words, for global tags we expect exactly 2 keys (tag and operand), with optional third key `strict`.
##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -72,7 +84,9 @@ More information about this new feature is available in the section <<common-que
*Autoscaling*
-* Solr now includes a default autoscaling policy.
+* **NOTE: The default autoscaling policy has been removed as of 8.6.1**
++
+Solr now includes a default autoscaling policy.
Review comment:
This statement conflicts with the statement above. 8.5.x and 8.6.1 includes default preferences but not the default policy.
##########
File path: solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
##########
@@ -814,7 +814,9 @@ public void execute(SimScenario scenario) throws Exception {
values.put(key, val);
}
for (String node : nodes) {
- scenario.cluster.getSimNodeStateProvider().simSetNodeValues(node, values);
+ Map<String, Object> newValues = new HashMap<>(scenario.cluster.getSimNodeStateProvider().simGetNodeValues(node));
Review comment:
+1, this fixed a genuine bug in < 8.6.0
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Clause.java
##########
@@ -686,7 +686,7 @@ boolean isShardAbsent() {
for (Row r : session.matrix) {
computedValueEvaluator.node = r.node;
SealedClause sealedClause = getSealedClause(computedValueEvaluator);
- if (!sealedClause.getGlobalTag().isPass(r)) {
+ if (r.isLive() && !sealedClause.getGlobalTag().isPass(r)) {
Review comment:
+1, this was a genuine bug in 8.5.
##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -34,17 +34,29 @@ Detailed steps for upgrading a Solr cluster are in the section <<upgrading-a-sol
If you are upgrading from 7.x, see the section <<Upgrading from 7.x Releases>> below.
-=== Solr 8.6.1
+=== Solr 8.6.1 (Upgrading from 8.6.0 only)
+
+See the https://cwiki.apache.org/confluence/display/SOLR/ReleaseNote861[8.6.1 Release Notes^]
+for an overview of the fixes included in Solr 8.6.1.
+
+When upgrading to 8.6.1 users should be aware of the following major changes from 8.6.0.
*Autoscaling*
* As mentioned in the 8.6 upgrade notes, a default autoscaling policy was provided starting in 8.6.0.
This default autoscaling policy resulted in increasingly slow collection creation calls in large clusters (50+ collections).
+
In 8.6.1 the default autoscaling policy has been removed, and clouds will not use autoscaling unless a policy has explicitly been created.
-In order to fix the performance degradations introduced in 8.6.0, merely upgrade to 8.6.1.
+If your cloud is running 8.6.0 and **not using an explicit autoscaling policy**, upgrade to 8.6.1 and remove the default cluster policy and preferences via the following command.
+Replace `localhost:8983` with your Solr endpoint.
++
+```
+curl -X POST -H 'Content-type:application/json' -d '{set-cluster-policy : [], set-cluster-preferences : []}' http://localhost:8983/api/cluster/autoscaling
Review comment:
Setting preferences to `[]` actually removes the default preferences that have always been implicitly present, so this changes the behavior as compared with 8.5 and earlier. We should only reset the cluster_policy to `[]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#issuecomment-670612283
Tested this out locally upgrading 8.6.0 -> 8.6.1 RC1 (failure) -> this PR (success)
Also added you to the CHANGES.txt Gus, thanks for all the invaluable help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465461582
##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -34,17 +34,24 @@ Detailed steps for upgrading a Solr cluster are in the section <<upgrading-a-sol
If you are upgrading from 7.x, see the section <<Upgrading from 7.x Releases>> below.
-=== Solr 8.6.1
+=== Solr 8.6.1 (Upgrading from 8.6.0 only)
*Autoscaling*
* As mentioned in the 8.6 upgrade notes, a default autoscaling policy was provided starting in 8.6.0.
This default autoscaling policy resulted in increasingly slow collection creation calls in large clusters (50+ collections).
+
In 8.6.1 the default autoscaling policy has been removed, and clouds will not use autoscaling unless a policy has explicitly been created.
-In order to fix the performance degradations introduced in 8.6.0, merely upgrade to 8.6.1.
+If your cloud has been upgraded to 8.6.0 and you wish to fix this performance degredations, upgrade to 8.6.1 and remove the default cluster policy via the following command.
+Replace `localhost:8983` with your Solr endpoint.
++
+```
+curl -X POST -H 'Content-type:application/json' -d '{set-cluster-policy : []}' http://localhost:8983/api/cluster/autoscaling
Review comment:
The other caveat is probably that they shouldn't run this command if they have been actively using autoscaling cluster policies before they upgraded to 8.6.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465871109
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Clause.java
##########
@@ -117,10 +117,10 @@ private Clause(Map<String, Object> m) {
strict = Boolean.parseBoolean(String.valueOf(m.getOrDefault("strict", "true")));
Optional<String> globalTagName = m.keySet().stream().filter(Policy.GLOBAL_ONLY_TAGS::contains).findFirst();
if (globalTagName.isPresent()) {
- globalTag = parse(globalTagName.get(), m);
- if (m.size() > 2) {
- throw new RuntimeException("Only one extra tag supported for the tag " + globalTagName.get() + " in " + toJSONString(m));
+ if (m.size() > 3) {
Review comment:
from my very limited understanding of this code it appears that something like
```
if (globalTagName.isPresent()) {
validateGlobalTag(m, globalTagName.get());
globalTag = parse(globalTagName.get(), m);
...
and
...
private void validateGlobalTag(Map<String, Object> m, String tagName) {
if (m.size() > 2) {
if (!m.containsKey("strict") || m.size() > 3) {
throw new RuntimeException("Only, 'strict' and one extra tag supported for the tag " + tagName + " in " + toJSONString(m));
}
}
}
```
would be the real intention here... but it would be great if @sigram could confirm that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r466657348
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Clause.java
##########
@@ -117,10 +117,10 @@ private Clause(Map<String, Object> m) {
strict = Boolean.parseBoolean(String.valueOf(m.getOrDefault("strict", "true")));
Optional<String> globalTagName = m.keySet().stream().filter(Policy.GLOBAL_ONLY_TAGS::contains).findFirst();
if (globalTagName.isPresent()) {
- globalTag = parse(globalTagName.get(), m);
- if (m.size() > 2) {
- throw new RuntimeException("Only one extra tag supported for the tag " + globalTagName.get() + " in " + toJSONString(m));
+ if (m.size() > 3) {
Review comment:
I think that's the logic Gus used. It's equivalent to:
```java
private void validateGlobalTag(Map<String, Object> m, String tagName) {
if (m.size() > 2) {
if (!(m.containsKey("strict") && m.size() == 3)) {
throw new RuntimeException("Only, 'strict' and one extra tag supported for the tag " + tagName + " in " + toJSONString(m));
}
}
}
```
This will error unless there are exactly 3 keys and once of them is `strict`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465461582
##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -34,17 +34,24 @@ Detailed steps for upgrading a Solr cluster are in the section <<upgrading-a-sol
If you are upgrading from 7.x, see the section <<Upgrading from 7.x Releases>> below.
-=== Solr 8.6.1
+=== Solr 8.6.1 (Upgrading from 8.6.0 only)
*Autoscaling*
* As mentioned in the 8.6 upgrade notes, a default autoscaling policy was provided starting in 8.6.0.
This default autoscaling policy resulted in increasingly slow collection creation calls in large clusters (50+ collections).
+
In 8.6.1 the default autoscaling policy has been removed, and clouds will not use autoscaling unless a policy has explicitly been created.
-In order to fix the performance degradations introduced in 8.6.0, merely upgrade to 8.6.1.
+If your cloud has been upgraded to 8.6.0 and you wish to fix this performance degredations, upgrade to 8.6.1 and remove the default cluster policy via the following command.
+Replace `localhost:8983` with your Solr endpoint.
++
+```
+curl -X POST -H 'Content-type:application/json' -d '{set-cluster-policy : []}' http://localhost:8983/api/cluster/autoscaling
Review comment:
The other caveat is probably that they shouldn't run this command if they have been actively using autoscaling before they upgraded to 8.6.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman merged pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r466670298
##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -72,7 +84,9 @@ More information about this new feature is available in the section <<common-que
*Autoscaling*
-* Solr now includes a default autoscaling policy.
+* **NOTE: The default autoscaling policy has been removed as of 8.6.1**
++
+Solr now includes a default autoscaling policy.
Review comment:
Fresh install of 8.5.2 gives me:
```
{
"triggers":{
".auto_add_replicas":{
"name":".auto_add_replicas",
"event":"nodeLost",
"waitFor":120,
"enabled":true,
"actions":[
{
"name":"auto_add_replicas_plan",
"class":"solr.AutoAddReplicasPlanAction"},
{
"name":"execute_plan",
"class":"solr.ExecutePlanAction"}]},
".scheduled_maintenance":{
"name":".scheduled_maintenance",
"event":"scheduled",
"startTime":"NOW",
"every":"+1DAY",
"enabled":true,
"actions":[
{
"name":"inactive_shard_plan",
"class":"solr.InactiveShardPlanAction"},
{
"name":"inactive_markers_plan",
"class":"solr.InactiveMarkersPlanAction"},
{
"name":"execute_plan",
"class":"solr.ExecutePlanAction"}]}},
"listeners":{
".auto_add_replicas.system":{
"beforeAction":[],
"afterAction":[],
"stage":[
"STARTED",
"ABORTED",
"SUCCEEDED",
"FAILED",
"BEFORE_ACTION",
"AFTER_ACTION",
"IGNORED"],
"trigger":".auto_add_replicas",
"class":"org.apache.solr.cloud.autoscaling.SystemLogListener"},
".scheduled_maintenance.system":{
"beforeAction":[],
"afterAction":[],
"stage":[
"STARTED",
"ABORTED",
"SUCCEEDED",
"FAILED",
"BEFORE_ACTION",
"AFTER_ACTION",
"IGNORED"],
"trigger":".scheduled_maintenance",
"class":"org.apache.solr.cloud.autoscaling.SystemLogListener"}},
"properties":{}}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465806654
##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -34,17 +34,24 @@ Detailed steps for upgrading a Solr cluster are in the section <<upgrading-a-sol
If you are upgrading from 7.x, see the section <<Upgrading from 7.x Releases>> below.
-=== Solr 8.6.1
+=== Solr 8.6.1 (Upgrading from 8.6.0 only)
*Autoscaling*
* As mentioned in the 8.6 upgrade notes, a default autoscaling policy was provided starting in 8.6.0.
This default autoscaling policy resulted in increasingly slow collection creation calls in large clusters (50+ collections).
+
In 8.6.1 the default autoscaling policy has been removed, and clouds will not use autoscaling unless a policy has explicitly been created.
-In order to fix the performance degradations introduced in 8.6.0, merely upgrade to 8.6.1.
+If your cloud has been upgraded to 8.6.0 and you wish to fix this performance degredations, upgrade to 8.6.1 and remove the default cluster policy via the following command.
+Replace `localhost:8983` with your Solr endpoint.
++
+```
+curl -X POST -H 'Content-type:application/json' -d '{set-cluster-policy : []}' http://localhost:8983/api/cluster/autoscaling
Review comment:
I tried to make this more clear. Let me know if you think my wording is off
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1716: SOLR-14706: Fix support for default autoscaling policy
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465146599
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Clause.java
##########
@@ -686,7 +686,7 @@ boolean isShardAbsent() {
for (Row r : session.matrix) {
computedValueEvaluator.node = r.node;
SealedClause sealedClause = getSealedClause(computedValueEvaluator);
- if (!sealedClause.getGlobalTag().isPass(r)) {
+ if (r.isLive() && !sealedClause.getGlobalTag().isPass(r)) {
Review comment:
I brought this back in from the revert because it looks like an improvement that was unrelated to the default policy.
I'm happy to remove it if y'all think I should.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org