You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/08/05 15:50:07 UTC
[GitHub] [hive] belugabehr opened a new pull request, #3506: HIVE-26456: Remove stringifyException Method From Storage Handlers
belugabehr opened a new pull request, #3506:
URL: https://github.com/apache/hive/pull/3506
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3506: HIVE-26456: Remove stringifyException Method From Storage Handlers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3506: HIVE-26456: Remove stringifyException Method From Storage Handlers
URL: https://github.com/apache/hive/pull/3506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #3506: HIVE-26456: Remove stringifyException Method From Storage Handlers
Posted by GitBox <gi...@apache.org>.
zabetak commented on code in PR #3506:
URL: https://github.com/apache/hive/pull/3506#discussion_r951498152
##########
accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java:
##########
@@ -386,7 +386,7 @@ public void testPushdownComparisonOptNotSupported() {
} catch (RuntimeException e) {
assertTrue(e.getMessage().contains("Unexpected residual predicate: field1 is not null"));
} catch (Exception e) {
- fail(StringUtils.stringifyException(e));
+ fail(e.getMessage());
}
Review Comment:
Remove unused `import org.apache.hadoop.util.StringUtils;`
##########
accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloStorageHandler.java:
##########
@@ -369,11 +369,7 @@ public void preCreateTable(Table table) throws MetaException {
tableOpts.create(idxTable);
}
}
- } catch (AccumuloSecurityException e) {
- throw new MetaException(StringUtils.stringifyException(e));
- } catch (TableExistsException e) {
- throw new MetaException(StringUtils.stringifyException(e));
- } catch (AccumuloException e) {
+ } catch (AccumuloSecurityException | TableExistsException | AccumuloException e) {
Review Comment:
In a previous PR (https://github.com/apache/hive/pull/3478) we opted to use the LOG + throw pattern as an alternative of removing `stringifyException` acknowledging advantages and disadvantages of it. Why we don't want to do the same here?
##########
accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java:
##########
@@ -386,7 +386,7 @@ public void testPushdownComparisonOptNotSupported() {
} catch (RuntimeException e) {
assertTrue(e.getMessage().contains("Unexpected residual predicate: field1 is not null"));
} catch (Exception e) {
- fail(StringUtils.stringifyException(e));
+ fail(e.getMessage());
}
Review Comment:
It seems we don't really need this catch.
##########
accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java:
##########
@@ -475,7 +474,7 @@ public void testIgnoreIteratorPushdown() throws TooManyAccumuloColumnsException
List<IteratorSetting> iterators = handler.getIterators(conf, columnMapper);
assertEquals(iterators.size(), 0);
} catch (Exception e) {
- fail(StringUtils.stringifyException(e));
+ fail(e.getMessage());
}
Review Comment:
Same comment as before.
##########
druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java:
##########
@@ -96,7 +96,7 @@ public class QTestDruidSerDe extends DruidSerDe {
DruidStorageHandlerUtils.JSON_MAPPER.readValue(RESPONSE, new TypeReference<List<SegmentAnalysis>>() {
});
} catch (Exception e) {
- throw new SerDeException(StringUtils.stringifyException(e));
+ throw new SerDeException(e);
Review Comment:
Remove unused `import org.apache.hadoop.util.StringUtils;`
##########
accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/mr/HiveAccumuloTableInputFormat.java:
##########
@@ -175,15 +175,8 @@ public InputSplit[] getSplits(JobConf jobConf, int numSplits) throws IOException
}
return hiveSplits;
- } catch (AccumuloException e) {
- log.error("Could not configure AccumuloInputFormat", e);
- throw new IOException(StringUtils.stringifyException(e));
- } catch (AccumuloSecurityException e) {
- log.error("Could not configure AccumuloInputFormat", e);
- throw new IOException(StringUtils.stringifyException(e));
- } catch (SerDeException e) {
- log.error("Could not configure AccumuloInputFormat", e);
- throw new IOException(StringUtils.stringifyException(e));
+ } catch (AccumuloException | AccumuloSecurityException | SerDeException e) {
+ throw new IOException("Could not configure AccumuloInputFormat", e);
Review Comment:
Remove unused `import org.apache.hadoop.util.StringUtils;`
##########
accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java:
##########
@@ -423,7 +423,6 @@ public void testIteratorIgnoreRowIDFields() {
List<IteratorSetting> iterators = handler.getIterators(conf, columnMapper);
assertEquals(iterators.size(), 0);
} catch (SerDeException e) {
- StringUtils.stringifyException(e);
}
Review Comment:
Ignoring the exception seems wrong. Most likely the test should fail in case of exception. Can we fix this as part of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #3506: HIVE-26456: Remove stringifyException Method From Storage Handlers
Posted by GitBox <gi...@apache.org>.
belugabehr commented on PR #3506:
URL: https://github.com/apache/hive/pull/3506#issuecomment-1206604216
@zabetak Here is another related PR. This doesn't totally wipe out the usage of stringifyException in these modules, but removes the low-hanging fruit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr closed pull request #3506: HIVE-26456: Remove stringifyException Method From Storage Handlers
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #3506: HIVE-26456: Remove stringifyException Method From Storage Handlers
URL: https://github.com/apache/hive/pull/3506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3506: HIVE-26456: Remove stringifyException Method From Storage Handlers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3506:
URL: https://github.com/apache/hive/pull/3506#issuecomment-1287556035
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org