You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Aaron T. Myers (Created) (JIRA)" <ji...@apache.org> on 2011/12/27 07:06:30 UTC

[jira] [Created] (HDFS-2724) NN web UI can throw NPE after startup, before standby state is entered

NN web UI can throw NPE after startup, before standby state is entered
----------------------------------------------------------------------

                 Key: HDFS-2724
                 URL: https://issues.apache.org/jira/browse/HDFS-2724
             Project: Hadoop HDFS
          Issue Type: Sub-task
          Components: ha, name-node
    Affects Versions: HA branch (HDFS-1623)
            Reporter: Aaron T. Myers
            Assignee: Eli Collins


There's a brief period of time (a few seconds) after the NN web server has been initialized, but before the NN's HA state is initialized. If {{dfshealth.jsp}} is hit during this time, a {{NullPointerException}} will be thrown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-2724) NN web UI can throw NPE after startup, before standby state is entered

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183227#comment-13183227 ] 

Hudson commented on HDFS-2724:
------------------------------

Integrated in Hadoop-Hdfs-HAbranch-build #43 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/43/])
    HDFS-2724. NN web UI can throw NPE after startup, before standby state is entered. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229466
Files : 
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp

                
> NN web UI can throw NPE after startup, before standby state is entered
> ----------------------------------------------------------------------
>
>                 Key: HDFS-2724
>                 URL: https://issues.apache.org/jira/browse/HDFS-2724
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Todd Lipcon
>             Fix For: HA branch (HDFS-1623)
>
>         Attachments: hdfs-2724.txt
>
>
> There's a brief period of time (a few seconds) after the NN web server has been initialized, but before the NN's HA state is initialized. If {{dfshealth.jsp}} is hit during this time, a {{NullPointerException}} will be thrown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-2724) NN web UI can throw NPE after startup, before standby state is entered

Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182701#comment-13182701 ] 

Eli Collins commented on HDFS-2724:
-----------------------------------

+1 lgtm, I like INITIALIZING better
                
> NN web UI can throw NPE after startup, before standby state is entered
> ----------------------------------------------------------------------
>
>                 Key: HDFS-2724
>                 URL: https://issues.apache.org/jira/browse/HDFS-2724
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2724.txt
>
>
> There's a brief period of time (a few seconds) after the NN web server has been initialized, but before the NN's HA state is initialized. If {{dfshealth.jsp}} is hit during this time, a {{NullPointerException}} will be thrown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-2724) NN web UI can throw NPE after startup, before standby state is entered

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-2724:
------------------------------

    Attachment: hdfs-2724.txt

Here's a candidate fix. The other way to do it would be to change the code in NameNode.initialize so that it sets the {{state}} variable before starting the IPC server. But I think actually adding the {{INITIALIZING}} state is slightly preferable. Let me know if you disagree.
                
> NN web UI can throw NPE after startup, before standby state is entered
> ----------------------------------------------------------------------
>
>                 Key: HDFS-2724
>                 URL: https://issues.apache.org/jira/browse/HDFS-2724
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2724.txt
>
>
> There's a brief period of time (a few seconds) after the NN web server has been initialized, but before the NN's HA state is initialized. If {{dfshealth.jsp}} is hit during this time, a {{NullPointerException}} will be thrown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HDFS-2724) NN web UI can throw NPE after startup, before standby state is entered

Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon resolved HDFS-2724.
-------------------------------

       Resolution: Fixed
    Fix Version/s: HA branch (HDFS-1623)
     Hadoop Flags: Reviewed

Committed to branch, thanks Eli.
                
> NN web UI can throw NPE after startup, before standby state is entered
> ----------------------------------------------------------------------
>
>                 Key: HDFS-2724
>                 URL: https://issues.apache.org/jira/browse/HDFS-2724
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Todd Lipcon
>             Fix For: HA branch (HDFS-1623)
>
>         Attachments: hdfs-2724.txt
>
>
> There's a brief period of time (a few seconds) after the NN web server has been initialized, but before the NN's HA state is initialized. If {{dfshealth.jsp}} is hit during this time, a {{NullPointerException}} will be thrown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-2724) NN web UI can throw NPE after startup, before standby state is entered

Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176096#comment-13176096 ] 

Aaron T. Myers commented on HDFS-2724:
--------------------------------------

Specifically, the error is:

{noformat}
11/12/26 14:51:08 ERROR mortbay.log: /dfshealth.jsp
java.lang.NullPointerException
  at org.apache.hadoop.hdfs.server.namenode.NameNode.getServiceState(NameNode.java:920)
  at org.apache.hadoop.hdfs.server.namenode.dfshealth_jsp._jspService(dfshealth_jsp.java:72)
  at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
  at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
  at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221)
  at org.apache.hadoop.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:109)
  at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
  at org.apache.hadoop.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:988)
  at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
  at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
  at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
  at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
  at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
  at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
  at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
  at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
  at org.mortbay.jetty.Server.handle(Server.java:326)
  at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
  at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
  at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
  at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
  at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
  at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
  at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
{noformat}
                
> NN web UI can throw NPE after startup, before standby state is entered
> ----------------------------------------------------------------------
>
>                 Key: HDFS-2724
>                 URL: https://issues.apache.org/jira/browse/HDFS-2724
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Eli Collins
>
> There's a brief period of time (a few seconds) after the NN web server has been initialized, but before the NN's HA state is initialized. If {{dfshealth.jsp}} is hit during this time, a {{NullPointerException}} will be thrown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HDFS-2724) NN web UI can throw NPE after startup, before standby state is entered

Posted by "Todd Lipcon (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon reassigned HDFS-2724:
---------------------------------

    Assignee: Todd Lipcon  (was: Eli Collins)
    
> NN web UI can throw NPE after startup, before standby state is entered
> ----------------------------------------------------------------------
>
>                 Key: HDFS-2724
>                 URL: https://issues.apache.org/jira/browse/HDFS-2724
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Todd Lipcon
>
> There's a brief period of time (a few seconds) after the NN web server has been initialized, but before the NN's HA state is initialized. If {{dfshealth.jsp}} is hit during this time, a {{NullPointerException}} will be thrown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira