You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/11/24 12:31:36 UTC
[GitHub] [thrift] rolesen opened a new pull request #2286: uncaught_exception -> uncaught_exceptions
rolesen opened a new pull request #2286:
URL: https://github.com/apache/thrift/pull/2286
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] rolesen closed pull request #2286: uncaught_exception -> uncaught_exceptions
Posted by GitBox <gi...@apache.org>.
rolesen closed pull request #2286:
URL: https://github.com/apache/thrift/pull/2286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] rolesen commented on pull request #2286: uncaught_exception -> uncaught_exceptions
Posted by GitBox <gi...@apache.org>.
rolesen commented on pull request #2286:
URL: https://github.com/apache/thrift/pull/2286#issuecomment-733598380
Hello
Thanks for reaching out.
Im a little new to github (It targeted the mother repo by default).
Just a warning on c++17/gcc.
I had some compilation errors I had to figure first also due to us using a
manual "config.h" file (we use "waf" build system).
But I plan to make it again when done.
Kind regards
Rune
tir. 24. nov. 2020 20.33 skrev Jens Geyer <no...@github.com>:
> Two identical PRs and then both closed. Mmmh, Can we help?
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/thrift/pull/2286#issuecomment-733188351>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AH2XM3JWEIT5CBEDB6MCLZ3SRQC67ANCNFSM4UA2KO3Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2286: uncaught_exception -> uncaught_exceptions
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2286:
URL: https://github.com/apache/thrift/pull/2286#issuecomment-733188351
Two identical PRs and then both closed. Mmmh, Can we help?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org