[jira] [Commented] (KAFKA-6731) waitOnState waits for the wrong state instead of the target one

["Guozhang Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421864#comment-16421864 ] 

Guozhang Wang commented on KAFKA-6731:
--------------------------------------

Good catch! It is indeed a bug. For now it is only called with NOT_RUNNING so we did not dispose it. But we should definitely fix it. Would you mind submitting a PR?

> waitOnState waits for the wrong state instead of the target one
> ---------------------------------------------------------------
>
>                 Key: KAFKA-6731
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6731
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: huxihx
>            Priority: Major
>
> In KafkaStreams.waitOnState, the code will waits the state to be set to NOT_RUNNING instead of the given target state. Is it deliberately as designed?
> {code:java}
> // ......
> while (state != State.NOT_RUNNING) {
>     if (waitMs == 0) {
>         try {
>             stateLock.wait();
>         } catch (final InterruptedException e) {
>             // it is ok: just move on to the next iteration
>         }
>     } else if (waitMs > elapsedMs) {
>         long remainingMs = waitMs - elapsedMs;
>         try {
>             stateLock.wait(remainingMs);
>         } catch (final InterruptedException e) {
>             // it is ok: just move on to the next iteration
>         }
>     } else {
>         log.debug("Cannot transit to {} within {}ms", targetState, waitMs);
>         return false;
>     }
>     elapsedMs = time.milliseconds() - begin;
> }
> return true;
> {code}
> IMO, it should check the state to be the target one. 
> [~guozhang] Does is make sense?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)