You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/12/04 20:31:00 UTC

[GitHub] [thrift] tylerchr commented on pull request #2288: THRIFT-5318: Update PHP thrift_protocol extension for PHP 8

tylerchr commented on pull request #2288:
URL: https://github.com/apache/thrift/pull/2288#issuecomment-739003410


   The `ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX` errors you referenced are fixed now. The underlying cause was this macro was changed in PHP 7.2 to its current form (I had tested with PHP 7.4 and PHP 8.0, but not earlier versions of PHP 7). My fix was to leave arginfo out in PHP 7 (where it's not required) and only include it for PHP 8 (where it is).
   
   That fixed the `Autotools (Ubuntu Xenial)` test. There are still failures in the `Autotools (Ubuntu Bionic)` and `UBSan` tests though. Can you help me understand the cause of those? (I didn't know anything about writing PHP extensions or the Thrift build infrastructure 72 hours ago and I'm learning all of this as I go.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org