You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/11/03 21:50:24 UTC
[GitHub] [buildstream] nanonyme opened a new pull request, #1785: bst1: Support Python 3.11
nanonyme opened a new pull request, #1785:
URL: https://github.com/apache/buildstream/pull/1785
Fixes https://github.com/apache/buildstream/issues/1758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] mcatanzaro commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
mcatanzaro commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371000251
Hi @gtristan, can you look at this please? buildstream 1 is really super broken currently, and for a very long time now (it's not like python 3.11 is new anymore).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] mcatanzaro commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
mcatanzaro commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371189362
> Will let you know how it goes....
Well it finished successfully, but I think it pulled everything from the artifact cache without actually building anything.
Want me to test anything else in particular?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371063786
@jjardon I am not taking about CI. Just install it and use it. It will not hang. See if there are further regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371019149
Note that this is about CI and testing on Python 3.11. This has no functional changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1349169260
I'm not entirely sure if tests hang on Fedora 36 and 37 but at least they're massively slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1349584262
Looks like there are failing tests. The failing tests are failing really slowly. I'm trying to make tests abort after first failure so we see real output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] mcatanzaro commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
mcatanzaro commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1317394557
Why is this still a draft?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371109027
@jjardon it also does not hang "forever". Asyncio gets into bad state and times out with 30 minutes at a time. It just times out dozens of times in a loop so it looks like forever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371304642
I created https://github.com/apache/buildstream/pull/1809 anyhow. I would like to have CI actually work before advertising Python 3.11 support in metadata. But this should hopefully unblock downstreams.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] jjardon commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
jjardon commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371059093
@mcatanzaro @nanonyme that is what is being done in #1757 (It hangs forever)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1349620192
Well, that was not overly useful. I got it to actually end and we're maybe a bit closer to understanding why the test is so slow https://github.com/apache/buildstream/actions/runs/3688689726/jobs/6243779599 but the traceback is mostly gibberish and there is no console output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371029351
There are unreleased fixes for Python3.11 in bst-1 branch. But without CI it's hard to say whether further things are broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371253035
I think that's strong indication we should wrap a quick release. If you can build something (doesn't matter what, you can force rebuild by setting environment variable in some element), that would be even better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1785: bst1: Support Python 3.11
Posted by "gtristan (via GitHub)" <gi...@apache.org>.
gtristan commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1438286403
This is replaced by #1827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan closed pull request #1785: bst1: Support Python 3.11
Posted by "gtristan (via GitHub)" <gi...@apache.org>.
gtristan closed pull request #1785: bst1: Support Python 3.11
URL: https://github.com/apache/buildstream/pull/1785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1349078904
I am not getting a pipeline, dunno why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371056715
It would be nice if someone pip installed bst1 from this repo who actually has Python3.11 to give it at least some lightweight manual testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] mcatanzaro commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
mcatanzaro commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371187413
> It would be nice if someone pip installed bst1 from this repo who actually has Python3.11 to give it at least some lightweight manual testing.
You don't have access to an F37 toolbx container? That should take maybe two minutes to create. Whatever. I installed this branch and am building gnome-build-meta with it now. Will let you know how it goes....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] mcatanzaro commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
mcatanzaro commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371387897
> I think that's strong indication we should wrap a quick release. If you can build something (doesn't matter what, you can force rebuild by setting environment variable in some element), that would be even better.
Did this to force building core/epiphany.bst. It worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1317504137
@mcatanzaro tests don't pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] mcatanzaro commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
mcatanzaro commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371024367
Oops, I see it is #1758 that requires attention, not this #1785.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] mcatanzaro commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
mcatanzaro commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371051443
Er, why not release them then? This has been blocking a lot of stuff for a long time.
(I agree that CI is very important, but it's not urgent.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371064679
If it seems usable, then we tag a release and worry about CI later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1785: bst1: Support Python 3.11
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1785:
URL: https://github.com/apache/buildstream/pull/1785#issuecomment-1371080938
The hangs are related to special way bst1 event loop is used for unittest purposes in same process restarting it over and over again. They are not indicative of real problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org