You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/18 05:10:46 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #38293: [SPARK-40828][CONNECT][PYTHON][TESTING] Drop Python test tables before and after unit tests

amaliujia commented on code in PR #38293:
URL: https://github.com/apache/spark/pull/38293#discussion_r997724002


##########
python/pyspark/testing/connectutils.py:
##########
@@ -74,7 +73,7 @@ def _udf_mock(cls, *args, **kwargs) -> str:
     @classmethod
     def setUpClass(cls: Any) -> None:
         cls.connect = MockRemoteSession()
-        cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "")
+        cls.tbl_name = "test_connect_plan_only_table_1"

Review Comment:
   We do not need to drop this because this table name works with `MockRemoteSession`. The table has never been created.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org