[GitHub] [geode] kirklund opened pull request #3197: GEODE-6409: Bounce VM in doesNotWaitForPreviousInstanceOfOnlineServer

["kirklund (GitHub)" <gi...@apache.org>]

Extract doesNotWaitForPreviousInstanceOfOnlineServer to
PersistentPartitionHangsDuringRestartRegressionTest.

Disable ENABLE_NETWORK_PARTITION_DETECTION and use bounceForcibly
instead of disconnecting vm0.

Also fixes GEODE-6356 with addIgnoredException for CancelException.

[ Full content available at: https://github.com/apache/geode/pull/3197 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #3197: GEODE-6409: Bounce VM in doesNotWaitForPreviousInstanceOfOnlineServer

["moleske (GitHub)" <gi...@apache.org>]

I realize this was copy paste, but references to bug numbers we can't get to really shouldn't be propagated if we can help it.  The rest of the comment could still be helpful it seems

[ Full content available at: https://github.com/apache/geode/pull/3197 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #3197: GEODE-6409: Bounce VM in doesNotWaitForPreviousInstanceOfOnlineServer

["kirklund (GitHub)" <gi...@apache.org>]

On one hand, I do have access to those bugs, and when I work on code that references a TRAC ticket in comments, it is sometimes useful that I can go learn more about the history of it. The javadoc describes the bug well and includes the full summary.

On the other hand, 1/2 or more of the people working on Geode don't have access. The TRAC ticket is noise to them unless they ask to have someone pull up that ticket and share details of it-- maybe it ends up having value since some of us can grab and share that history with the Geode community?

I think I'm not the right person to remove these since I think they can be useful, but removing all TRAC tickets from comments/javadocs in Geode might be a good discussion on the dev-list. I do always convert test class and method names from testBug45666 to something more meaningful and then copy the full summary and try to describe what the bug was in javadocs. Sometimes I do delete the info if I'm sure there's no value in it. I wouldn't disapprove a PR that removes the references as I think both view points are valid.

[ Full content available at: https://github.com/apache/geode/pull/3197 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #3197: GEODE-6409: Bounce VM in doesNotWaitForPreviousInstanceOfOnlineServer

["moleske (GitHub)" <gi...@apache.org>]

Sounds good, I'll look to start a dev thread.

[ Full content available at: https://github.com/apache/geode/pull/3197 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #3197: GEODE-6409: Bounce VM in doesNotWaitForPreviousInstanceOfOnlineServer

["kirklund (GitHub)" <gi...@apache.org>]

[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/3197 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #3197: GEODE-6409: Bounce VM in doesNotWaitForPreviousInstanceOfOnlineServer

["kirklund (GitHub)" <gi...@apache.org>]

@demery-pivotal please review

[ Full content available at: https://github.com/apache/geode/pull/3197 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org