You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/04/26 23:06:10 UTC
[GitHub] [pinot] walterddr opened a new issue, #8597: [Feature] create FunctionRegistry based on argument type not argument count
walterddr opened a new issue, #8597:
URL: https://github.com/apache/pinot/issues/8597
Currently Pinot's [FunctionRegistry](https://github.com/apache/pinot/blob/89836a57c0d2346e4a04d43c8a9d8ef1e7900b18/pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java) registers and looks up function based on name and function argument count. this causes problem that we can't register 2 function with the same name but different function argument type. for example `sum(int, int)` and `sum(long, long)`
Propose to change a FunctionRegistry to accept lookup based on argument type.
- `Map<String, Map<Integer, FunctionInfo>> FUNCTION_INFO_MAP;` will be changed to be of type: `Map<String, Map<Collection<DataType>, FunctionInfo>>`.
- Lookup will now support both argument count and argument type list.
Note: this depends on LiteralContext in #8596 as there's backward incompatible Literal argument type issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org