You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/13 18:21:33 UTC

[GitHub] [helix] pkuwm commented on pull request #1464: Fix MaxCapacityUsageGauge value not updated

pkuwm commented on pull request #1464:
URL: https://github.com/apache/helix/pull/1464#issuecomment-707924672


   This PR is ready to be merged, approved by @NealSun96 @jiajunwang 
   
   MaxCapacityUsageGauge value not updated because the resourcesToMonitor map is empty.
   
   This commit fixes the bug and also adds an integration test to protect the metrics reporting logic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org