You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/07 08:32:19 UTC
[GitHub] [dolphinscheduler] rockfang opened a new pull request, #9936: [Fix #9925]: fix ellipsis bug in table column
rockfang opened a new pull request, #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936
## Purpose of the pull request
close [#9925 ](https://github.com/apache/dolphinscheduler/issues/9925)
## Brief change log
use an independent NEllipsis instead of `ellipsis config in NDataTable`
## Verify this pull request
This pull request is code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#issuecomment-1120588081
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9936)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9936&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9936&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9936&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#issuecomment-1120167563
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9936?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9936](https://codecov.io/gh/apache/dolphinscheduler/pull/9936?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd2e4f4) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/40ab72d325ea9f47653ffb6bec267547d78781d6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40ab72d) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev #9936 +/- ##
=========================================
Coverage 40.30% 40.30%
- Complexity 4529 4530 +1
=========================================
Files 835 835
Lines 33750 33750
Branches 3727 3727
=========================================
+ Hits 13602 13603 +1
Misses 18858 18858
+ Partials 1290 1289 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/9936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `53.52% <0.00%> (+0.70%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9936?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9936?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [40ab72d...dd2e4f4](https://codecov.io/gh/apache/dolphinscheduler/pull/9936?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] labbomb commented on a diff in pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
labbomb commented on code in PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#discussion_r867365884
##########
dolphinscheduler-ui/src/views/projects/list/use-table.ts:
##########
@@ -76,23 +76,22 @@ export function useTable() {
title: t('project.list.project_name'),
key: 'name',
className: 'project-name',
- ...COLUMN_WIDTH_CONFIG['name'],
+ width: 200,
render: (row: { code: string; name: any }) =>
h(
- NEllipsis,
- { style: 'max-width: 200px; color: #2080f0' },
+ ButtonLink,
+ {
+ onClick: () => {
+ router.push({ path: `/projects/${row.code}` })
+ }
+ },
{
default: () =>
h(
- ButtonLink,
- {
- onClick: () => {
- router.push({ path: `/projects/${row.code}` })
- }
- },
- { default: () => row.name }
- ),
- tooltip: () => row.name
+ NEllipsis,
+ { style: 'max-width: 180px;line-height: 1.5' },
Review Comment:
Set width to the same as that specified in config, like: (max-width: 100px)
##########
dolphinscheduler-ui/src/views/projects/list/use-table.ts:
##########
@@ -76,23 +76,22 @@ export function useTable() {
title: t('project.list.project_name'),
key: 'name',
className: 'project-name',
- ...COLUMN_WIDTH_CONFIG['name'],
Review Comment:
you'd better not delete the content of config
##########
dolphinscheduler-ui/src/views/projects/list/use-table.ts:
##########
@@ -76,23 +76,22 @@ export function useTable() {
title: t('project.list.project_name'),
key: 'name',
className: 'project-name',
- ...COLUMN_WIDTH_CONFIG['name'],
+ width: 200,
Review Comment:
There's no need to add this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] rockfang commented on pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
rockfang commented on PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#issuecomment-1120379084
> thanks,I reviewed a file and gave an example, and other files were also modified by reference
hi bro, I didn't find your review and example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#issuecomment-1120168532
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9936)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9936&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9936&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9936&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9936&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet merged pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
songjianet merged PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] rockfang commented on pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
rockfang commented on PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#issuecomment-1120589390
@labbomb hi bro. i modifyid it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] labbomb commented on pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
labbomb commented on PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#issuecomment-1120230617
thanks,I reviewed a file and gave an example, and other files were also modified by reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] labbomb commented on pull request #9936: [Fix #9925]: fix ellipsis bug in table column
Posted by GitBox <gi...@apache.org>.
labbomb commented on PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#issuecomment-1120396234
> > thanks,I reviewed a file and gave an example, and other files were also modified by reference
>
> hi bro, I didn't find your review and example.
<img width="633" alt="image" src="https://user-images.githubusercontent.com/15062456/167293044-1782346d-f280-4eb1-a996-d06a34df0176.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org