You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org> on 2011/08/02 15:13:28 UTC
[jira] [Created] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
[HDFS-362] Provide ShortWritable class in hadoop.
-------------------------------------------------
Key: HADOOP-7493
URL: https://issues.apache.org/jira/browse/HADOOP-7493
Project: Hadoop Common
Issue Type: New Feature
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076188#comment-13076188 ]
Uma Maheswara Rao G commented on HADOOP-7493:
---------------------------------------------
This patch will be tested along with HDFS-362.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Status: Patch Available (was: Open)
Updated patch against trunk.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Status: Patch Available (was: Open)
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7493:
-------------------------------------------
Component/s: io
Hadoop Flags: [Reviewed]
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Attachment: HADOOP-7493.3.patch
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Attachment: HADOOP-7493.patch
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086305#comment-13086305 ]
Hadoop QA commented on HADOOP-7493:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490647/HADOOP-7493.3_root.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/43//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/43//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/43//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/43//console
This message is automatically generated.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086352#comment-13086352 ]
Hudson commented on HADOOP-7493:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #747 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/747/])
HADOOP-7493. Add ShortWritable. Constributed by Uma Maheswara Rao G
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158733
Files :
* /hadoop/common/trunk/hadoop-common/src/test/java/org/apache/hadoop/io/TestWritable.java
* /hadoop/common/trunk/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common/src/main/java/org/apache/hadoop/io/ShortWritable.java
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086206#comment-13086206 ]
Hadoop QA commented on HADOOP-7493:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490630/HADOOP-7493.3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/42//console
This message is automatically generated.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Affects Version/s: 0.23.0
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Status: Open (was: Patch Available)
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7493:
-------------------------------------------
Attachment: HADOOP-7493.3_root.patch
+1 patch looks good.
Seems that Jenkins expects the patch to be generated from the root. Let's give a try.
HADOOP-7493.3b.patch: same patch generated from root.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086369#comment-13086369 ]
Uma Maheswara Rao G commented on HADOOP-7493:
---------------------------------------------
Thanks Nicholas,
Regarding the below comment
{quote}
There is a warning: WritableComparable is a raw type. References to generic type WritableComparable<T> should be parameterized
{quote}
shall i file separate Jira to fix in other writables as well?
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086374#comment-13086374 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7493:
------------------------------------------------
Sure, please file a JIRA for it.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Attachment: HADOOP-7493.1.patch
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Status: Patch Available (was: Open)
Hi Eli,
Thanks a lot for taking a look!
Initially why i did not provided separate tests here is, HDFS-362 will ShortWritable completely, So, actual testing will happen through that.
I agree with you.
To commit it separately, we must have separate tests. I have provided the tests separately in Common itself along with HADOOP-7953.2.patch now.
--Thanks
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086020#comment-13086020 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7493:
------------------------------------------------
- There is a warning: WritableComparable is a raw type. References to generic type WritableComparable<T> should be parameterized
- Why converting shorts to ints?
{code}
+ int thisValue = (short) readUnsignedShort(b1, s1);
+ int thatValue = (short) readUnsignedShort(b2, s2);
{code}
- Please add @Override tags.
- There are many tailing spaces in the license header. Please remove them.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084671#comment-13084671 ]
Uma Maheswara Rao G commented on HADOOP-7493:
---------------------------------------------
test-patch results are:
Checking the integrity of system test framework code.
======================================================================
====================================================================
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9
) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 system test framework. The patch passed system test framework compile.
======================================================================
======================================================================
Finished build.
======================================================================
====================================================================
Verified the tests as well, there is no test failures because of this change.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Attachment: (was: HADOOP-7493.patch)
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086334#comment-13086334 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7493:
------------------------------------------------
According to the [console output|https://builds.apache.org/job/PreCommit-HADOOP-Build/43/console], the core tests were not executed.
{noformat}
There are no tests to run.
Results :
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
{noformat}
However, I was able to run tests locally.
{noformat}
Results :
Tests run: 1337, Failures: 0, Errors: 0, Skipped: 0
{noformat}
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7493:
--------------------------------
Status: Open (was: Patch Available)
This patch doesn't have any test coverage, eg in TestWritable.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086306#comment-13086306 ]
Hadoop QA commented on HADOOP-7493:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490647/HADOOP-7493.3_root.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/44//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/44//console
This message is automatically generated.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086211#comment-13086211 ]
Uma Maheswara Rao G commented on HADOOP-7493:
---------------------------------------------
Manually i can applied the patch successfully by using svn option.
After that i ran the testpatch commands
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9
) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 system test framework. The patch passed system test framework compile.
Looks some issue with hudson.
Also there is not failures because of this patch.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Status: Patch Available (was: Open)
Hi Nicholas,
Thanks a lot for taking a look and also thanks for the good comments.
{quote}There is a warning: WritableComparable is a raw type. References to generic type WritableComparable<T> should be parameterized
{quote}
Fixed.
Javadoc example class need to correct in WritableComparable interface.
I am planning to file other issue for correcting all other writables. What do you say?
{quote}Why converting shorts to ints?
+ int thisValue = (short) readUnsignedShort(b1, s1);
+ int thatValue = (short) readUnsignedShort(b2, s2);
{quote}
Anyway return type will be converted to int right. So, i put them as ints.
Changed to shorts
{quote}Please add @Override tags.{quote}
done.
{quote}There are many tailing spaces in the license header. Please remove them.
corrected.{quote}
My observation is that, hadoop coding formatter is not removing the training spaces.
Is it the same case for you? if yes, shall we file one JIRA for correcting this?
Because i copied that header from some other class (i dont remember exactly), looks that file also might have the same. If we have capture this rule in coding formatter itself, we will not miss this kind of small style issues.
--Thanks
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7493:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Uma!
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Status: Open (was: Patch Available)
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------
Attachment: HADOOP-7953.2.patch
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7493) [HDFS-362] Provide ShortWritable
class in hadoop.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086397#comment-13086397 ]
Uma Maheswara Rao G commented on HADOOP-7493:
---------------------------------------------
filed the JIRA HADOOP-7547
--Thanks
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7493.3_root.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira