You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Kay Schieck (JIRA)" <ji...@apache.org> on 2007/08/20 18:07:31 UTC
[jira] Created: (PLUTO-420) Parameters not x-www-form-urlencoded
Parameters not x-www-form-urlencoded
------------------------------------
Key: PLUTO-420
URL: https://issues.apache.org/jira/browse/PLUTO-420
Project: Pluto
Issue Type: Bug
Components: portlet container
Affects Versions: 1.1-286-COMPATIBILITY
Environment: apache-tomcat-5.5.23
Linux
java version "1.5.0_12"
Reporter: Kay Schieck
It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
For instance
PortletURL.setParameter("Ä & ü", "< ö >");
leads to
http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Benjamin Gould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Gould updated PLUTO-420:
---------------------------------
Attachment: testcase-patch.txt
I updated the testcase patch to include a check for spaces in the generated URL.
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt, testcase-patch.txt, url-parser-patch.txt
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523499 ]
Torsten Dettborn commented on PLUTO-420:
----------------------------------------
Committed URL_Parser_And_TestCase_Merged_Combine_from_Benjamin_082907.patch for 1.1.286-Compability Version. The new rev. number is 570689.
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt, testcase-patch.txt, url-parser-patch.txt, URL_Parser_And_TestCase_Merged_Combine_from_Benjamin_082907.patch
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Dettborn updated PLUTO-420:
-----------------------------------
Affects Version/s: 1.1-286-trunk-merge
i add affects Version, so it is easier to merge 1.1-286-Compatibility and 1.1-286-trunk-merge Version.
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt, testcase-patch.txt, url-parser-patch.txt, URL_Parser_And_TestCase_Merged_Combine_from_Benjamin_082907.patch
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522676 ]
Craig Doremus commented on PLUTO-420:
-------------------------------------
This appears to be a violation of PLT.11.1.1 of the JSR-168 spec. Benjamin, please do create a patch and I will commit it to Subversion.
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Benjamin Gould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522001 ]
Benjamin Gould commented on PLUTO-420:
--------------------------------------
I verified this using pluto-testsuite. I'm attaching a patch to RenderParameterTest demonstrating Kay's use case described above. I'm not really sure if it is a major functional problem, since it seems like my web browser (firefox) properly encodes the generated URL when I try to navigate to it. Anyhow, we could simply run all of the encode* methods on o.a.p.driver.url.impl.PortalURLParser through encodeQueryParam() after they do their work in order solve this issue.
Pluto-dev, please comment on this; I'll create a fix patch if that's the way you want to go.
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 1.1-286-COMPATIBILITY
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Benjamin Gould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Gould updated PLUTO-420:
---------------------------------
Component/s: (was: portlet container)
portal driver
Affects Version/s: 1.2.0
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Benjamin Gould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Gould updated PLUTO-420:
---------------------------------
Attachment: testcase-patch.txt
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Benjamin Gould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Gould updated PLUTO-420:
---------------------------------
Attachment: url-parser-patch.txt
I made the following changes to the URL parser:
1) Every variable that goes into the URL gets passed through URLEncoder.encode
2) I changed it so that the render path get passed through the character encoder upon url generation and through the decoder upon parsing. This means that if a page name has a character escape sequence (eg, 0x9), bad things could happen. Not really sure how to avoid/fix this.
3) Added "+" as a character to be encoded, since the URL encoder seems to encode both " " and "+" as "+". Please verify this.
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt, testcase-patch.txt, url-parser-patch.txt
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma resolved PLUTO-420.
-----------------------------
Resolution: Fixed
Applied long time ago
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY, 2.0.0
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt, testcase-patch.txt, url-parser-patch.txt, URL_Parser_And_TestCase_Merged_Combine_from_Benjamin_082907.patch
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-420) Parameters not x-www-form-urlencoded
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Dettborn updated PLUTO-420:
-----------------------------------
Attachment: URL_Parser_And_TestCase_Merged_Combine_from_Benjamin_082907.patch
This patch combines the URL_Parser and TestCase Patch from Benjamin Gould. I merged it with the actual revision and combine them to the new patch. Hope this was ok.
> Parameters not x-www-form-urlencoded
> ------------------------------------
>
> Key: PLUTO-420
> URL: https://issues.apache.org/jira/browse/PLUTO-420
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.2.0, 1.1-286-COMPATIBILITY
> Environment: apache-tomcat-5.5.23
> Linux
> java version "1.5.0_12"
> Reporter: Kay Schieck
> Attachments: testcase-patch.txt, testcase-patch.txt, url-parser-patch.txt, URL_Parser_And_TestCase_Merged_Combine_from_Benjamin_082907.patch
>
>
> It seems that parameters added to a PortletURL not converted to a x-www-form-urlencoded figure.
> For instance
> PortletURL.setParameter("Ä & ü", "< ö >");
> leads to
> http://localhost:8080/pluto/portal//TCK00004/__rp0x3portlet0x1jp0x1RenderRequest0x1web0x2GetPublicParameterSetNullTestPortlet_Ä & ü/0x60x8ö0x80x7?"
> The key and a part of he value is not encodet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.