[GitHub] [helix] lei-xia commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider.

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider.
URL: https://github.com/apache/helix/pull/458#discussion_r322961760
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/common/caches/BasicClusterDataCache.java
 ##########
 @@ -38,8 +37,32 @@
 public class BasicClusterDataCache {
   private static Logger LOG = LoggerFactory.getLogger(BasicClusterDataCache.class.getName());
 
-  protected Map<String, LiveInstance> _liveInstanceMap;
-  protected Map<String, InstanceConfig> _instanceConfigMap;
+  private static final String INSTANCE_CONFIG = "InstanceConfig";
+  private static final String LIVE_INSTANCE = "LiveInstance";
+  private static final ControlContextProvider DUMMY_CONTROL_CONTEXT_PROVIDER =
 
 Review comment:
   maybe a better name?  DUMMY seems not so serious in prod code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org