You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2010/05/03 17:06:46 UTC
Re: Contributer Patches - Committers Requested
On 04/22/2010 02:04 PM, Kerry Bonin wrote:
> I'd also suggest the patch I made w/ QPID-1904 - The C++ AbsTime&
> Duration values are not set to a consistent epoch, which causes
> problems when you try using QMF timestamps across Linux and Windows,
> and even on Windows when you try and talk between Python and C++
> clients. I submitted a patch which forces the epoch to that specified
> in AMQP, instead of inheriting it from the platform, which seems quite
> wrong for a network protocol across platforms with differing native
> epochs. The epoch is calculated once, and the conversion was already
> relative to a base, so there should be no performance hit.
>
There is already an EPOCH constant in Time.h that is consistent for windows &
posix, it was added recently. Does this address your issue?
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: Contributer Patches - Committers Requested
Posted by Andrew Stitcher <as...@redhat.com>.
On Mon, 2010-05-03 at 11:06 -0400, Alan Conway wrote:
> On 04/22/2010 02:04 PM, Kerry Bonin wrote:
> > I'd also suggest the patch I made w/ QPID-1904 - The C++ AbsTime&
> > Duration values are not set to a consistent epoch, which causes
> > problems when you try using QMF timestamps across Linux and Windows,
> > and even on Windows when you try and talk between Python and C++
> > clients. I submitted a patch which forces the epoch to that specified
> > in AMQP, instead of inheriting it from the platform, which seems quite
> > wrong for a network protocol across platforms with differing native
> > epochs. The epoch is calculated once, and the conversion was already
> > relative to a base, so there should be no performance hit.
> >
>
> There is already an EPOCH constant in Time.h that is consistent for windows &
> posix, it was added recently. Does this address your issue?
I checked in a fix for QPID_1904 last week.
A
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org