[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1155: Fix cppcoreguidelines-macro-usage warning reported by clang-tidy

[GitBox <gi...@apache.org>]

PragmaTwice commented on code in PR #1155:
URL: https://github.com/apache/incubator-kvrocks/pull/1155#discussion_r1038949149


##########
src/types/geohash.h:
##########
@@ -122,6 +114,14 @@ struct GeoHashRadius {
   GeoHashNeighbors neighbors;
 };
 
+inline constexpr bool HASHISZERO(const GeoHashBits &r) { return !r.bits && !r.step; }
+inline constexpr bool RANGEISZERO(const GeoHashRange &r) { return !r.max && !r.min; }
+inline constexpr bool RANGEPISZERO(const GeoHashRange *r) { return r == nullptr || RANGEISZERO(*r); }

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org