You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/19 00:41:58 UTC
[GitHub] [kafka] akhileshchg opened a new pull request, #13130: Fix upgrade compatibility issue from older versions to 3.4
akhileshchg opened a new pull request, #13130:
URL: https://github.com/apache/kafka/pull/13130
3.4 introduced a change that requires cluster.id to be present in meta.properties if the file is available. This information is not persisted by the brokers in old versions (< 0.10). So on upgrade, the requirement check fails and halts the broker start-up. Fixed the requirement to ensure cluster.id is not required in zk mode on upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] akhileshchg commented on a diff in pull request #13130: Fix upgrade compatibility issue from older versions to 3.4
Posted by GitBox <gi...@apache.org>.
akhileshchg commented on code in PR #13130:
URL: https://github.com/apache/kafka/pull/13130#discussion_r1080739852
##########
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##########
@@ -157,7 +157,8 @@ case class MetaProperties(
object BrokerMetadataCheckpoint extends Logging {
def getBrokerMetadataAndOfflineDirs(
logDirs: collection.Seq[String],
- ignoreMissing: Boolean
+ ignoreMissing: Boolean,
+ kraftMode: Boolean = false
Review Comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah merged pull request #13130: Fix upgrade compatibility issue from older versions to 3.4
Posted by GitBox <gi...@apache.org>.
mumrah merged PR #13130:
URL: https://github.com/apache/kafka/pull/13130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #13130: Fix upgrade compatibility issue from older versions to 3.4
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #13130:
URL: https://github.com/apache/kafka/pull/13130#discussion_r1080736930
##########
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##########
@@ -157,7 +157,8 @@ case class MetaProperties(
object BrokerMetadataCheckpoint extends Logging {
def getBrokerMetadataAndOfflineDirs(
logDirs: collection.Seq[String],
- ignoreMissing: Boolean
+ ignoreMissing: Boolean,
+ kraftMode: Boolean = false
Review Comment:
Default arguments like this make it easy to miss places that should be updated. Better to be explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org