[GitHub] [helix] pkuwm commented on pull request #1383: Add Metrics for External Custom Health Check Requests

[GitBox <gi...@apache.org>]

pkuwm commented on pull request #1383:
URL: https://github.com/apache/helix/pull/1383#issuecomment-701561320


   Thanks, all, for the review!
   
   This PR is ready to be merged, approved by @kaisun2000 @alirezazamani 
   
   ```
   Custom rest client interacts with participant side to query for its health checks. Currently there is no metrics for the query requests. We'd like to have metrics for the external http requests.
   
   This commit adds http request latency, requests total and error http request total metrics for the custom rest client calls.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org