[GitHub] [airflow] jhtimmins commented on pull request #8637: Changes deprecated config check rules.

[GitBox <gi...@apache.org>]

jhtimmins commented on pull request #8637:
URL: https://github.com/apache/airflow/pull/8637#issuecomment-621541510


   @dimberman This addresses an incompatibility between versions 1.10 and 2. For the `hostname_callable` config value, the notation changed from using colons (`socket:getfqdn`) to periods (`socket.getfqdn`). 
   
   This is a problem if you already have an airflow.cfg file (or unittest.cfg) from < 2.0, as airflow will continue to use the out-of-date values and throw an error. This branch does the following:
   1. Adds shim code to replace the colon w/ a period. 
   2. Modifies the way that deprecated config values are swapped out. Previously, they did it with simple string comparison. This uses a regex to search for and replace the values, because it's possible to use a custom `hostname_callable` value that is formatted in the deprecated manner. Using a regex gives more control about what constitutes a deprecated value.
   3. Adds FutureWarning alert when the deprecated style is in use.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org