[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344316779
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
 ##########
 @@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw, HRegionInfo region,
     try {
       rt = RegionTransition.createRegionTransition(
           endState, region.getRegionName(), serverName, payload);
-      if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+      boolean isDataSet;
+      try {
+        isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion());
+      } catch (KeeperException.BadVersionException e) {
+        isDataSet = false;
+        LOG.info("Received BadVersionException from ZK for " + encoded
 
 Review comment:
   That is true but for most of the cases of all branch-1s use `org.apache.commons.logging.Log`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services