You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/08/22 21:01:55 UTC
[GitHub] [maven] famod opened a new pull request #527: [MNG-7220] [3.8.x] Fix threadLocalArtifactsHolder leaking into cloned project
famod opened a new pull request #527:
URL: https://github.com/apache/maven/pull/527
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] famod commented on a change in pull request #527: [MNG-7220] [3.8.x] Fix threadLocalArtifactsHolder leaking into cloned project
Posted by GitBox <gi...@apache.org>.
famod commented on a change in pull request #527:
URL: https://github.com/apache/maven/pull/527#discussion_r693556958
##########
File path: maven-core/src/main/java/org/apache/maven/project/MavenProject.java
##########
@@ -1232,11 +1239,6 @@ private void deepCopy( MavenProject project )
setDependencyArtifacts( Collections.unmodifiableSet( project.getDependencyArtifacts() ) );
}
- if ( project.getArtifacts() != null )
- {
- setArtifacts( Collections.unmodifiableSet( project.getArtifacts() ) );
Review comment:
This didn't make any sense anymore because the entire holder is now copied already (see further up).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] famod commented on a change in pull request #527: [MNG-7220] [3.8.x] Fix threadLocalArtifactsHolder leaking into cloned project
Posted by GitBox <gi...@apache.org>.
famod commented on a change in pull request #527:
URL: https://github.com/apache/maven/pull/527#discussion_r693557431
##########
File path: maven-core/src/main/java/org/apache/maven/project/MavenProject.java
##########
@@ -1232,11 +1239,6 @@ private void deepCopy( MavenProject project )
setDependencyArtifacts( Collections.unmodifiableSet( project.getDependencyArtifacts() ) );
}
- if ( project.getArtifacts() != null )
Review comment:
Yeah, please see this comment of mine: https://github.com/apache/maven/pull/527#discussion_r693556958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #527: [MNG-7220] [3.8.x] Fix threadLocalArtifactsHolder leaking into cloned project
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #527:
URL: https://github.com/apache/maven/pull/527#discussion_r693557271
##########
File path: maven-core/src/main/java/org/apache/maven/project/MavenProject.java
##########
@@ -1232,11 +1239,6 @@ private void deepCopy( MavenProject project )
setDependencyArtifacts( Collections.unmodifiableSet( project.getDependencyArtifacts() ) );
}
- if ( project.getArtifacts() != null )
Review comment:
This is now gone because of the deep copy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o closed pull request #527: [MNG-7220] [3.8.x] Fix threadLocalArtifactsHolder leaking into cloned project
Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #527:
URL: https://github.com/apache/maven/pull/527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #527: [MNG-7220] [3.8.x] Fix threadLocalArtifactsHolder leaking into cloned project
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #527:
URL: https://github.com/apache/maven/pull/527#issuecomment-919291936
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org