You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/05 06:28:33 UTC

[GitHub] [pulsar] lhotari commented on pull request #10480: [Broker] Fix race condition in invalidating ledger cache entries

lhotari commented on pull request #10480:
URL: https://github.com/apache/pulsar/pull/10480#issuecomment-832445354


   > Actually, I'm not 100% sure that the having invalidations called by multiple thread could lead to the issue. In all the cases the entries are removed from the `ConcurrentSkipList` before getting release, and the guarantee there is that the removal should be atomic.
   
   This is true. Therefore, thinking of the changes as a safety measure and way to detect the source of the problem as [explained in my previous comment](#discussion_r626277254) could be the rationale for adding a separate method for invalidation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org