You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/31 04:51:36 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4764: Fix the bug
of releasing the segment when there are still threads working on it
codecov-io commented on issue #4764: Fix the bug of releasing the segment when there are still threads working on it
URL: https://github.com/apache/incubator-pinot/pull/4764#issuecomment-548215897
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4764?src=pr&el=h1) Report
> Merging [#4764](https://codecov.io/gh/apache/incubator-pinot/pull/4764?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/5439e77f60d6f7efb78acc928a58ba64eca87fee?src=pr&el=desc) will **increase** coverage by `7.85%`.
> The diff coverage is `74.07%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4764?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4764 +/- ##
===========================================
+ Coverage 49.95% 57.8% +7.85%
Complexity 4 4
===========================================
Files 1209 1209
Lines 64938 64964 +26
Branches 9458 9463 +5
===========================================
+ Hits 32437 37551 +5114
+ Misses 29942 24556 -5386
- Partials 2559 2857 +298
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4764?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/pinot/core/operator/BaseOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9CYXNlT3BlcmF0b3IuamF2YQ==) | `21.42% <0%> (-3.58%)` | `0 <0> (ø)` | |
| [...rg/apache/pinot/core/operator/CombineOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lT3BlcmF0b3IuamF2YQ==) | `69.44% <66.66%> (+8.83%)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/core/operator/CombineGroupByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lR3JvdXBCeU9wZXJhdG9yLmphdmE=) | `83.69% <77.77%> (+7.83%)` | `0 <0> (ø)` | :arrow_down: |
| [...t/core/operator/CombineGroupByOrderByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lR3JvdXBCeU9yZGVyQnlPcGVyYXRvci5qYXZh) | `79.8% <77.77%> (+7.08%)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/pinot/core/plan/CombinePlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0NvbWJpbmVQbGFuTm9kZS5qYXZh) | `78.68% <87.5%> (+1.9%)` | `0 <0> (ø)` | :arrow_down: |
| [...inot/transport/netty/NettyTCPClientConnection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvbmV0dHkvTmV0dHlUQ1BDbGllbnRDb25uZWN0aW9uLmphdmE=) | `81.45% <0%> (-3.32%)` | `0% <0%> (ø)` | |
| [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `70.42% <0%> (+0.63%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `88.8% <0%> (+0.72%)` | `0% <0%> (ø)` | :arrow_down: |
| [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `89.71% <0%> (+0.82%)` | `0% <0%> (ø)` | :arrow_down: |
| [...e/io/writer/impl/MutableOffHeapByteArrayStore.java](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9NdXRhYmxlT2ZmSGVhcEJ5dGVBcnJheVN0b3JlLmphdmE=) | `85.71% <0%> (+1.09%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [292 more](https://codecov.io/gh/apache/incubator-pinot/pull/4764/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4764?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4764?src=pr&el=footer). Last update [5439e77...36e603d](https://codecov.io/gh/apache/incubator-pinot/pull/4764?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org