[GitHub] [airflow] pankajastro commented on a diff in pull request #25587: New Operators for the Google Cloud Dataform service

[GitBox <gi...@apache.org>]

pankajastro commented on code in PR #25587:
URL: https://github.com/apache/airflow/pull/25587#discussion_r940504233


##########
airflow/providers/google/cloud/hooks/dataform.py:
##########
@@ -0,0 +1,252 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import time
+from typing import Dict, Optional, Sequence, Tuple, Union
+
+from google.api_core.gapic_v1.method import DEFAULT, _MethodDefault
+from google.api_core.retry import Retry
+from google.cloud.dataform_v1beta1 import DataformClient
+from google.cloud.dataform_v1beta1.types import CompilationResult, WorkflowInvocation
+
+from airflow import AirflowException
+from airflow.providers.google.common.hooks.base_google import GoogleBaseHook
+
+
+class DataformHook(GoogleBaseHook):
+    """Hook for Google Cloud DataForm APIs."""
+
+    def get_dataform_client(
+        self,
+    ) -> DataformClient:
+        """Retrieves client library object that allow access to Cloud Dataform service."""
+        return DataformClient(credentials=self._get_credentials())
+
+    @GoogleBaseHook.fallback_to_default_project_id
+    def wait_for_workflow_invocation(
+        self,
+        workflow_invocation_id: str,
+        repository_id: str,
+        project_id: str,
+        region: str,
+        wait_time: int = 10,

Review Comment:
   We should expose `wait_time` in the operator also so that an user can control it.



##########
airflow/providers/google/cloud/hooks/dataform.py:
##########
@@ -0,0 +1,252 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import time
+from typing import Dict, Optional, Sequence, Tuple, Union
+
+from google.api_core.gapic_v1.method import DEFAULT, _MethodDefault
+from google.api_core.retry import Retry
+from google.cloud.dataform_v1beta1 import DataformClient
+from google.cloud.dataform_v1beta1.types import CompilationResult, WorkflowInvocation
+
+from airflow import AirflowException
+from airflow.providers.google.common.hooks.base_google import GoogleBaseHook
+
+
+class DataformHook(GoogleBaseHook):
+    """Hook for Google Cloud DataForm APIs."""
+
+    def get_dataform_client(
+        self,
+    ) -> DataformClient:
+        """Retrieves client library object that allow access to Cloud Dataform service."""
+        return DataformClient(credentials=self._get_credentials())
+
+    @GoogleBaseHook.fallback_to_default_project_id
+    def wait_for_workflow_invocation(
+        self,
+        workflow_invocation_id: str,
+        repository_id: str,
+        project_id: str,
+        region: str,
+        wait_time: int = 10,

Review Comment:
   We should expose `wait_time` in the operator also so that a user can control it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org