You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "mlsorensen (via GitHub)" <gi...@apache.org> on 2023/09/06 20:57:29 UTC
[GitHub] [cloudstack] mlsorensen opened a new pull request, #7948: Use direct download timeout configs for URL check during registerTemplate
mlsorensen opened a new pull request, #7948:
URL: https://github.com/apache/cloudstack/pull/7948
### Description
This PR allows the direct download timeout configurations to apply to the URL check during registerTemplate.
There is already support in the Downloader classes for these configurations for the actual download of templates, and the ConfigKeys already exist, so just needed to pass these in the CheckUrlCommand
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested locally, confirmed config items are passed along.
mgmt server:
```
2023-09-06 14:41:09,340 DEBUG [c.c.a.m.ClusteredAgentAttache] (qtp1911152052-21:ctx-09dfd07c ctx-600dfd34) (logid:1083f2be) (extid:) Seq 43-7668222790528401454: Forwarding Seq 43-7668222790528401454: { Cmd , MgmtId: 31239355356821, via: 43(kvmlab2), Ver: v1, Flags: 100011, [{"org.apache.cloudstack.agent.directdownload.CheckUrlCommand":{"format":"QCOW2","url":"https://download.fedoraproject.org/pub/fedora/linux/releases/37/Cloud/x86_64/images/Fedora-Cloud-Base-37-1.7.x86_64.qcow2","connectTimeout":"7000","connectionRequestTimeout":"5000","socketTimeout":"8000","wait":"0","bypassHostMaintenance":"false"}}] } to 5074163034
2023-09-06 14:41:11,405 DEBUG [c.c.a.t.Request] (AgentManager-Handler-8:null) (logid:) (extid:) Seq 43-7668222790528401454: Processing: { Ans: , MgmtId: 31239355356821, via: 43, Ver: v1, Flags: 10, [{"org.apache.cloudstack.agent.directdownload.CheckUrlAnswer":{"templateSize":"(5.00 GB) 5368709120","result":"true","wait":"0","bypassHostMaintenance":"false"}}] }
```
hypervisor:
```
2023-09-06 14:41:09,385 DEBUG [cloud.agent.Agent] (agentRequest-Handler-4:null) (logid:1083f2be) Request:Seq 43-7668222790528401454: { Cmd , MgmtId: 31239355356821, via: 43, Ver: v1, Flags: 100011, [{"org.apache.cloudstack.agent.directdownload.CheckUrlCommand":{"format":"QCOW2","url":"https://download.fedoraproject.org/pub/fedora/linux/releases/37/Cloud/x86_64/images/Fedora-Cloud-Base-37-1.7.x86_64.qcow2","connectTimeout":"7000","connectionRequestTimeout":"5000","socketTimeout":"8000","wait":"0","bypassHostMaintenance":"false"}}] }
2023-09-06 14:41:09,386 DEBUG [cloud.agent.Agent] (agentRequest-Handler-4:null) (logid:1083f2be) Processing command: org.apache.cloudstack.agent.directdownload.CheckUrlCommand
2023-09-06 14:41:09,386 INFO [resource.wrapper.LibvirtCheckUrlCommand] (agentRequest-Handler-4:null) (logid:1083f2be) Checking URL: https://download.fedoraproject.org/pub/fedora/linux/releases/37/Cloud/x86_64/images/Fedora-Cloud-Base-37-1.7.x86_64.qcow2, with connect timeout: 7000, connect request timeout: 5000, socket timeout: 8000
2023-09-06 14:41:11,404 DEBUG [cloud.agent.Agent] (agentRequest-Handler-4:null) (logid:1083f2be) Seq 43-7668222790528401454: { Ans: , MgmtId: 31239355356821, via: 43, Ver: v1, Flags: 10, [{"org.apache.cloudstack.agent.directdownload.CheckUrlAnswer":{"templateSize":"(5.00 GB) 5368709120","result":"true","wait":"0","bypassHostMaintenance":"false"}}] }
```
Updated unit tests to use the new constructor.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948#issuecomment-1711899584
@mlsorensen a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948#issuecomment-1709184043
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7948?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7948](https://app.codecov.io/gh/apache/cloudstack/pull/7948?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b6ae580) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/57c61fb33cf0a4587983d8b39b6aadd58a26a9b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (57c61fb) will **decrease** coverage by `0.01%`.
> Report is 1 commits behind head on 4.18.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.18 #7948 +/- ##
============================================
- Coverage 13.06% 13.06% -0.01%
+ Complexity 9097 9096 -1
============================================
Files 2720 2720
Lines 257465 257471 +6
Branches 40146 40146
============================================
- Hits 33643 33634 -9
- Misses 219594 219610 +16
+ Partials 4228 4227 -1
```
| [Files Changed](https://app.codecov.io/gh/apache/cloudstack/pull/7948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...r/kvm/resource/wrapper/LibvirtCheckUrlCommand.java](https://app.codecov.io/gh/apache/cloudstack/pull/7948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0Q2hlY2tVcmxDb21tYW5kLmphdmE=) | `13.33% <0.00%> (-3.34%)` | :arrow_down: |
| [.../com/cloud/template/HypervisorTemplateAdapter.java](https://app.codecov.io/gh/apache/cloudstack/pull/7948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3RlbXBsYXRlL0h5cGVydmlzb3JUZW1wbGF0ZUFkYXB0ZXIuamF2YQ==) | `1.88% <0.00%> (-0.02%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7948/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948#issuecomment-1709403475
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mlsorensen commented on pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "mlsorensen (via GitHub)" <gi...@apache.org>.
mlsorensen commented on PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948#issuecomment-1711898852
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948#issuecomment-1712402978
<b>[SF] Trillian test result (tid-7654)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40486 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7948-t7654-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948#issuecomment-1709437616
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948#issuecomment-1735552365
@mlsorensen @nvazquez can you advice if this functionality is already covoured by the existing smoketests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7948: Use direct download timeout configs for URL check during registerTemplate
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7948:
URL: https://github.com/apache/cloudstack/pull/7948#issuecomment-1709403289
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org