You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/10/13 08:34:49 UTC
(superset) branch ultraset-metric-filter-none-iterable-oxfmt-drift updated (4e04f13aeee -> f97a51f49c6)
This is an automated email from the ASF dual-hosted git repository.
sadpandajoe pushed a change to branch ultraset-metric-filter-none-iterable-oxfmt-drift
in repository https://gitbox.apache.org/repos/asf/superset.git
discard 4e04f13aeee style(explore): lift the Selector css comment out of the arrow body
new f97a51f49c6 style(explore): lift the Selector css comment out of the arrow body
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (4e04f13aeee)
\
N -- N -- N refs/heads/ultraset-metric-filter-none-iterable-oxfmt-drift (f97a51f49c6)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
(superset) 01/01: style(explore): lift the Selector css comment out of the arrow body
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
sadpandajoe pushed a commit to branch ultraset-metric-filter-none-iterable-oxfmt-drift
in repository https://gitbox.apache.org/repos/asf/superset.git
commit f97a51f49c6b4a62fb9b614396e3ef1c8a629568
Author: Joe Li <jo...@preset.io>
AuthorDate: Tue Oct 13 08:33:28 2026 +0000
style(explore): lift the Selector css comment out of the arrow body
oxfmt 0.72.0 formats a comment sitting between the arrow and a tagged
template body by trailing it after the arrow and dedenting the template,
a shape found nowhere else in the frontend. Moving the comment above the
css prop — the form already used a few hundred lines up in this same
file — lets oxfmt collapse the arrow to the single-line form that 294
other call sites in the frontend use.
Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
---
.../explore/components/controls/VizTypeControl/VizTypeGallery.tsx | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
index 04639f2d3fe..31c43ff0fef 100644
--- a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
+++ b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
@@ -716,8 +716,8 @@ export default function VizTypeGallery(props: VizTypeGalleryProps) {
>
<LeftPane aria-label={t('Choose chart type')} role="tablist">
<Selector
- css={({ sizeUnit }) => // adjust style for not being inside a collapse
- css`
+ // adjust style for not being inside a collapse
+ css={({ sizeUnit }) => css`
margin: ${sizeUnit * 2}px;
margin-bottom: 0;
`}
@@ -732,8 +732,8 @@ export default function VizTypeGallery(props: VizTypeGalleryProps) {
onClick={clickSelector}
/>
<Selector
- css={({ sizeUnit }) => // adjust style for not being inside a collapse
- css`
+ // adjust style for not being inside a collapse
+ css={({ sizeUnit }) => css`
margin: ${sizeUnit * 2}px;
margin-bottom: 0;
`}