You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/16 09:28:21 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5239: net/tcp/sendfile: NET_TCP_WRITE_BUFFERS and NET_SENDFILE were inconsistent with each other

xiaoxiang781216 commented on a change in pull request #5239:
URL: https://github.com/apache/incubator-nuttx/pull/5239#discussion_r785413378



##########
File path: net/tcp/tcp_sendfile.c
##########
@@ -495,6 +495,9 @@ ssize_t tcp_sendfile(FAR struct socket *psock, FAR struct file *infile,
    */
 
   net_lock();
+#ifdef CONFIG_NET_TCP_WRITE_BUFFERS
+  conn->sendfile = true;

Review comment:
       should we let sendfile simulate the normal send behavior to avoid adding a new flag? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org