You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/07/22 23:51:57 UTC

[Impala-ASF-CR] IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24623


Change subject: IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds
......................................................................

IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds

MetaProviderDecoratorTest.testMetaProviderMethodCount tests
that MetaProvider has a specific number of public methods.
Jacoco code coverage adds its own '$jacocoInit' method, and
this throws the count off. This filters out Jacoco's method
to avoid the discrepancy.

Testing:
 - Ran MetaProviderDecoratorTest.testMetaProviderMethodCount
   with code coverage

Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
---
M fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/24623/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
Gerrit-Change-Number: 24623
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24623 )

Change subject: IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/23357/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
Gerrit-Change-Number: 24623
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 00:13:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24623 )

Change subject: IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds
......................................................................

IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds

MetaProviderDecoratorTest.testMetaProviderMethodCount tests
that MetaProvider has a specific number of public methods.
Jacoco code coverage adds its own '$jacocoInit' method, and
this throws the count off. This filters out Jacoco's method
to avoid the discrepancy.

Testing:
 - Ran MetaProviderDecoratorTest.testMetaProviderMethodCount
   with code coverage

Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
Reviewed-on: http://gerrit.cloudera.org:8080/24623
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Smith: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
Gerrit-Change-Number: 24623
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24623 )

Change subject: IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
Gerrit-Change-Number: 24623
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 16:00:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24623 )

Change subject: IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13778/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
Gerrit-Change-Number: 24623
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 00:14:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24623 )

Change subject: IMPALA-15207: Fix MetaProviderDecoratorTest for code coverage builds
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74576817db5f4f7550cce3740061cd6cde1afea1
Gerrit-Change-Number: 24623
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 05:07:06 +0000
Gerrit-HasComments: No