You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/10 01:29:52 UTC
[GitHub] [incubator-mxnet] leezu opened a new pull request #19108: Fix race condition in NaiveEngine::PushAsync
leezu opened a new pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108
Wait for async_fun to complete in NaiveEngine::PushAsync.
This fixes a race condition in which NaiveEngine::PushAsync was checking if the
the async_fun had completed by the end of NaiveEngine::PushAsync scope.
If async_fun hadn't completed yet, NaiveEngine::PushAsync would set an internal error string
and deallocate the callback, causing segfault in async_fun once it would attempt
calling the callback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690828960
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-691130293
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
ptrendx commented on a change in pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#discussion_r486512156
##########
File path: src/engine/naive_engine.cc
##########
@@ -208,8 +210,7 @@ class NaiveEngine final : public Engine {
for (auto var : mutable_vars) {
++var->version_;
}
- CHECK(req_completed)
- << "NaiveEngine only support synchronize Push so far";
+ future.wait();
Review comment:
With naive engine it does not really make a difference but generally speaking this wait should be before the `version_` increment, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690786494
https://github.com/thrust/thrust/issues/1090 comes back with high frequency in this PR... 10 compilation attempts in a row failed (each CI run attempts compilation 5 times before giving up).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-691130293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690828983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690784523
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-689916348
Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, miscellaneous, windows-cpu, windows-gpu, centos-gpu, clang, edge, unix-cpu, unix-gpu, centos-cpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-689931430
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690710929
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-691130373
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690468911
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690828960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690711026
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690828983
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19108: Fix race condition in NaiveEngine::PushAsync
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#issuecomment-690784562
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org