[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #646: [core] add read batch size option

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #646:
URL: https://github.com/apache/incubator-paimon/pull/646#discussion_r1141655103


##########
paimon-common/src/main/java/org/apache/paimon/format/FileFormatFactory.java:
##########
@@ -25,5 +25,5 @@ public interface FileFormatFactory {
 
     String identifier();
 
-    FileFormat create(Options formatOptions);
+    FileFormat create(Options formatOptions, int readBatchSize);

Review Comment:
   Maybe just create a class `FormatContext`:
   ```
   FormatContext {
       Options formatOptions();
       int readBatchSize();
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org