You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/03/04 20:19:08 UTC
[GitHub] [storm] RuiLi8080 commented on issue #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic
resource in grading topologies
RuiLi8080 commented on issue #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies
URL: https://github.com/apache/storm/pull/3213#issuecomment-594812990
@kishorvpatil Thanks for your review. As I addressed your comment, I noticed that we actually can cache all types of total cluster resources since the superviors snapshot won't change in cluster object.
So we don't need to add another getClusterGenericResourceTypes() function. We can just cache generic resources map and only fetch the keySet while we need it.
I also added cache for CPU and memory in latest commit, any further comments would be appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services