You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/30 10:44:37 UTC
[GitHub] [spark] Smeb opened a new pull request #28071: update rand()
function documentation to indicate exclusive upper bound
Smeb opened a new pull request #28071: update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071
### What changes were proposed in this pull request?
A small documentation change to clarify that the `rand()` function produces values in `[0.0, 1.0)`
### Why are the changes needed?
`rand()` uses `Rand()` - which generates values in [0, 1) ([documented here](https://github.com/apache/spark/blob/a1dbcd13a3eeaee50cc1a46e909f9478d6d55177/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala#L71)). The existing documentation suggests that 1.0 is a possible value returned by rand (i.e for a distribution written as `X ~ U(a, b)`, x can be a or b, so `U[0.0, 1.0]` suggests the value returned could include 1.0).
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Documentation changes only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28071: [SPARK-31306][DOCS]
update rand() function documentation to indicate exclusive upper bound
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606338840
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25321/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606414615
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28071: [SPARK-31306][DOCS]
update rand() function documentation to indicate exclusive upper bound
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606414095
**[Test build #120619 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120619/testReport)** for PR 28071 at commit [`5768671`](https://github.com/apache/spark/commit/5768671f4e6f33b4bd6a21ea586657d78fcb8b86).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606414615
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28071: [SPARK-31306][DOCS]
update rand() function documentation to indicate exclusive upper bound
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606336123
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28071: [SPARK-31306][DOCS]
update rand() function documentation to indicate exclusive upper bound
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606423589
Merged to master, branch-3.0 and branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606338829
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606338420
**[Test build #120619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120619/testReport)** for PR 28071 at commit [`5768671`](https://github.com/apache/spark/commit/5768671f4e6f33b4bd6a21ea586657d78fcb8b86).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606338840
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25321/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28071: update rand()
function documentation to indicate exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28071: update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-605926277
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28071: update
rand() function documentation to indicate exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28071: update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-605925689
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28071: [SPARK-31306][DOCS]
update rand() function documentation to indicate exclusive upper bound
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606338420
**[Test build #120619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120619/testReport)** for PR 28071 at commit [`5768671`](https://github.com/apache/spark/commit/5768671f4e6f33b4bd6a21ea586657d78fcb8b86).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606414623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120619/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606338829
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-605926277
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28071:
[SPARK-31306][DOCS] update rand() function documentation to indicate
exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28071: [SPARK-31306][DOCS] update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-606414623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120619/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28071: update rand()
function documentation to indicate exclusive upper bound
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28071: update rand() function documentation to indicate exclusive upper bound
URL: https://github.com/apache/spark/pull/28071#issuecomment-605925689
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org