You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/01/28 07:33:56 UTC
[PR] Verify JDK 9 classes. [incubator-pekko]
He-Pin opened a new pull request, #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064
Just for testing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#discussion_r1468789499
##########
.github/workflows/verify-jdk9-classes.yml:
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Verify JDK9 classes
+
+on:
+ pull_request:
+
+permissions:
+ contents: read
+
+jobs:
+ verify-jdk9-classes-check:
+ name: Verify JDK9 classes
+ runs-on: ubuntu-20.04
+ if: github.repository == 'apache/incubator-pekko'
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ fetch-tags: true
+
+ - name: Setup Java 11
+ uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: 11
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6
+
+ - name: Publish Stream module local
+ run: sbt ";set doc / skip := true; publishLocal ;"
+
+ - name: Install scala-cli
+ run: |-
+ curl -sS "https://virtuslab.github.io/scala-cli-packages/KEY.gpg" | sudo gpg --dearmor -o /etc/apt/trusted.gpg.d/scala-cli.gpg 2>/dev/null
+ sudo curl -s --compressed -o /etc/apt/sources.list.d/scala_cli_packages.list "https://virtuslab.github.io/scala-cli-packages/debian/scala_cli_packages.list"
+ sudo apt update
+ sudo apt install scala-cli
+
+ - name: Use Scala-CLI to check
+ run: |-
+ scala-cli --version
+ echo "Starting verification with Scala-CLI"
+ scala-cli stream/target/scala-cli/VerifyJDK9Classes.sc && echo "Verification successful" || (
+ echo "Error when VerifyJDK9Classes"
+ exit 1
Review Comment:
I will move this to the nightly build once checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913509274
@mdedetrich Do you mean `unzip | find`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#discussion_r1468812714
##########
project/VerifyJDK9Classes.scala:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+object VerifyJDK9Classes {
+ import sbt.*
Review Comment:
use `._` in imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#discussion_r1468813574
##########
project/VerifyJDK9Classes.scala:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+object VerifyJDK9Classes {
+ import sbt.*
+ import sbt.Keys.*
+
+ lazy val settings: Seq[Setting[_]] = inConfig(Compile) {
+ Seq {
+ sourceGenerators += {
+ generateAndWriteScalaCLIScript(
+ target,
+ _ / "scala-cli" / "VerifyJDK9Classes.sc")
+ }
+ }
+ }
+
+ def generateAndWriteScalaCLIScript(dir: SettingKey[File], locate: File => File): Def.Initialize[Task[Seq[sbt.File]]] =
+ Def.task[Seq[File]] {
+ val script = generateScalaCLIScript(version.value)
+ val file = locate(dir.value)
+ val content = script.stripMargin.format(version.value)
+ if (!file.exists || IO.read(file) != content) IO.write(file, content)
+ // the generated file is not used.
+ Nil
+ }
+
+ private def generateScalaCLIScript(version: String): String =
+ s"""
+ |/*
+ | * Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
That will not test the result jar, at least I don't know how to now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913549580
@mdedetrich Of course, I'm looking forward to your improvements, at least our community has polished our build a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913545502
> @mdedetrich Do you mean `unzip | find`?
Yup, even an awk ontop just to parse out the bytecode header in the `.class` file to see if it matches the JDK 9 bytecode version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#discussion_r1468868413
##########
project/VerifyJDK9Classes.scala:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+object VerifyJDK9Classes {
+ import sbt._
+ import sbt.Keys._
+
+ lazy val settings: Seq[Setting[_]] = inConfig(Compile) {
+ Seq {
+ sourceGenerators += {
+ generateAndWriteScalaCLIScript(
+ target,
+ _ / "scala-cli" / "VerifyJDK9Classes.sc")
+ }
+ }
+ }
+
+ def generateAndWriteScalaCLIScript(dir: SettingKey[File], locate: File => File): Def.Initialize[Task[Seq[sbt.File]]] =
+ Def.task[Seq[File]] {
+ val script = generateScalaCLIScript(version.value)
+ val file = locate(dir.value)
+ val content = script.stripMargin.format(version.value)
+ if (!file.exists || IO.read(file) != content) IO.write(file, content)
+ // the generated file is not used.
+ Nil
+ }
+
+ private def generateScalaCLIScript(version: String): String =
+ s"""
+ |/*
+ | * Licensed to the Apache Software Foundation (ASF) under one or more
+ | * contributor license agreements. See the NOTICE file distributed with
+ | * this work for additional information regarding copyright ownership.
+ | * The ASF licenses this file to You under the Apache License, Version 2.0
+ | * (the "License"); you may not use this file except in compliance with
+ | * the License. You may obtain a copy of the License at
+ | *
+ | * http://www.apache.org/licenses/LICENSE-2.0
+ | *
+ | * Unless required by applicable law or agreed to in writing, software
+ | * distributed under the License is distributed on an "AS IS" BASIS,
+ | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ | * See the License for the specific language governing permissions and
+ | * limitations under the License.
+ | */
+ |//> using scala 2.13
+ |//> using dep "org.apache.pekko::pekko-stream:${version}"
+ |////> using jvm 11
+ |object VerifyJDK9Classes {
+ | def main(args: Array[String]): Unit = {
+ | import org.apache.pekko.actor.ActorSystem
+ | import org.apache.pekko.stream.scaladsl.{ JavaFlowSupport, Source }
+ |
+ | import java.lang.System.exit
+ | import scala.concurrent.Await
+ | import scala.concurrent.duration.DurationInt
+ | implicit val system: ActorSystem = ActorSystem.create("test")
+ | val future = Source(1 to 3).runWith(
+ | JavaFlowSupport.Sink.asPublisher[Int](fanout = false).mapMaterializedValue { p =>
Review Comment:
I have reviewed this for a while, i am kind of understand why this PR does.
A simple `grep` pipeline connected to unzip results only checks some of the classes, once these class names change or delete, we have to upgrade the CI too.
Another way that parse out the bytecode header, I think it was too complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#discussion_r1468812890
##########
project/VerifyJDK9Classes.scala:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+object VerifyJDK9Classes {
+ import sbt.*
Review Comment:
Oh, Yes, but It will work now AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913547275
Because I'm going back to my hometown the day after tomorrow, I want to help resolve some blocker issues for 1.1.0-M1. At least I think this solution can solve the issues associated with it, and it's not such a strange solution because there is already a VersionGenerator now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913546227
@mdedetrich
The difference is that this approach can test whether the final product really works properly, rather than just checking if xxx.class exists using grep. I think this is a relatively advantageous point. In addition, it can expand to test multiple platforms' products, while if you use grep xxx.class in the end, can only determine whether xxx.class exists, right? At least I saw that Dotty uses this approach as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913543512
@pjfanning I only added this to the nightly build, which I think should be enough, if you like, I think we can add a dedicated job to test this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#discussion_r1468813212
##########
project/VerifyJDK9Classes.scala:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+object VerifyJDK9Classes {
+ import sbt.*
+ import sbt.Keys.*
+
+ lazy val settings: Seq[Setting[_]] = inConfig(Compile) {
+ Seq {
+ sourceGenerators += {
+ generateAndWriteScalaCLIScript(
+ target,
+ _ / "scala-cli" / "VerifyJDK9Classes.sc")
+ }
+ }
+ }
+
+ def generateAndWriteScalaCLIScript(dir: SettingKey[File], locate: File => File): Def.Initialize[Task[Seq[sbt.File]]] =
+ Def.task[Seq[File]] {
+ val script = generateScalaCLIScript(version.value)
+ val file = locate(dir.value)
+ val content = script.stripMargin.format(version.value)
+ if (!file.exists || IO.read(file) != content) IO.write(file, content)
+ // the generated file is not used.
+ Nil
+ }
+
+ private def generateScalaCLIScript(version: String): String =
+ s"""
+ |/*
+ | * Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
why not just check in this script instead of generating it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913548563
I understand you too. But in another post, you said we still need to support Java 8 for a while. If we eventually migrate to only supporting Java 11, then this can naturally be deleted, as the project is still in incubation. I think we can bear this cost to ensure our products don't become a laughing stock and to ensure supply chain security, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913518380

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913488991
As an alternate suggestion, wouldn't it be simpler to just check the header for some specific `.class` file that we know should be compiled with JDK9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913548995
> I understand you too. But in another post, you said we still need to support Java 8 for a while. If we eventually migrate to only supporting Java 11, then this can naturally be deleted, as the project is still in incubation. I think we can bear this cost to ensure our products don't become a laughing stock and to ensure supply chain security, right?
Sure, as I said I will accept either solution.
I think there may be a more elegant/simpler one we can talk about/do later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913547643
> @mdedetrich The difference is that this approach can test whether the final product really works properly, rather than just checking if xxx.class exists using grep. I think this is a relatively advantageous point. In addition, it can expand to test multiple platforms' products, while if you use grep xxx.class in the end, can only determine whether xxx.class exists, right? At least I saw that Dotty uses this approach as well.
I understand and I will accept either solution. My main reason for suggesting the simpler approach is that our issue is quite black and white, either the JDK 9 classes don't get generated at all or they get generated with the correct JDK version and if they do its completely correct.
Hence I think that checking whether it works is a bit excessive because at that point we are basically checking the scalac compiler is working where as what our historic issue has been is that the misconfiguration of sbt-osgi/multijvm/etc etc means that certain classes don't get compiled/included
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Verify JDK 9 classes. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1064:
URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913894054
@mdedetrich @pjfanning I have rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org