You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/15 18:10:26 UTC
[GitHub] [arrow-datafusion] avantgardnerio opened a new pull request, #3153: Remove date code no longer needed since arrow-rs PR 2031 merge
avantgardnerio opened a new pull request, #3153:
URL: https://github.com/apache/arrow-datafusion/pull/3153
# Which issue does this PR close?
Closes this comment https://github.com/apache/arrow-datafusion/pull/3110#discussion_r945973316
# Rationale for this change
We added code that is no longer needed, thanks to upstream merges in `arrow-rs` & `chrono`
# What changes are included in this PR?
Removal of temporary code.
# Are there any user-facing changes?
The requirement to have a newer chrono.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3153: Remove date code no longer needed since arrow-rs PR 2031 merge
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3153:
URL: https://github.com/apache/arrow-datafusion/pull/3153#issuecomment-1215607256
🤔 github claims it has conflicts -- maybe it needs a rebase against master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3153: Remove date code no longer needed since arrow-rs PR 2031 merge
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3153:
URL: https://github.com/apache/arrow-datafusion/pull/3153#issuecomment-1215592944
Looks great -- the CI hasn't yet run on this PR, but when it does I am feeling good about it 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3153: Remove date code no longer needed since arrow-rs PR 2031 merge
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on PR #3153:
URL: https://github.com/apache/arrow-datafusion/pull/3153#issuecomment-1215545423
@alamb heads up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] avantgardnerio closed pull request #3153: Remove date code no longer needed since arrow-rs PR 2031 merge
Posted by GitBox <gi...@apache.org>.
avantgardnerio closed pull request #3153: Remove date code no longer needed since arrow-rs PR 2031 merge
URL: https://github.com/apache/arrow-datafusion/pull/3153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3153: Remove date code no longer needed since arrow-rs PR 2031 merge
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on PR #3153:
URL: https://github.com/apache/arrow-datafusion/pull/3153#issuecomment-1215631278
> thinking github claims it has conflicts -- maybe it needs a rebase against master?
Unfortunately due to the implementation of this:
[xxx](https://github.com/apache/arrow-datafusion/blob/15a9a4becc4bb41262b10f1d5395fc1d026de753/datafusion/physical-expr/src/expressions/datetime.rs#L295)
I think we have to wait for this:
https://github.com/chronotope/chrono/pull/778
So that we can do this:
```
fn do_date_math<D>(prior: D, scalar: &ScalarValue, sign: i32) -> Result<D>
where
D: Datelike + Add<Duration, Output = D> + Add<Months, Output = D>,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org