You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ChiaPing Tsai (JIRA)" <ji...@apache.org> on 2016/09/01 11:21:21 UTC
[jira] [Created] (HBASE-16541) Avoid unnecessary cell copy in
Result.compareResults
ChiaPing Tsai created HBASE-16541:
-------------------------------------
Summary: Avoid unnecessary cell copy in Result.compareResults
Key: HBASE-16541
URL: https://issues.apache.org/jira/browse/HBASE-16541
Project: HBase
Issue Type: Improvement
Reporter: ChiaPing Tsai
Priority: Trivial
{code:title=Bar.java|borderStyle=solid}
// Bytes.equals(a, b) should be replaced by Bytes.equals(a, off, len, b, off len);
public static void compareResults(Result res1, Result res2)
throws Exception {
...
Cell[] ourKVs = res1.rawCells();
Cell[] replicatedKVs = res2.rawCells();
for (int i = 0; i < res1.size(); i++) {
if (!ourKVs[i].equals(replicatedKVs[i]) ||
!Bytes.equals(CellUtil.cloneValue(ourKVs[i]), CellUtil.cloneValue(replicatedKVs[i]))) {
throw new Exception("This result was different: "
+ res1.toString() + " compared to " + res2.toString());
}
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)