You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 06:30:38 UTC
[GitHub] [airflow] uranusjr commented on a change in pull request #20091: Remove deprecated method call (blob.download_as_string)
uranusjr commented on a change in pull request #20091:
URL: https://github.com/apache/airflow/pull/20091#discussion_r763675175
##########
File path: airflow/providers/google/cloud/hooks/gcs.py
##########
@@ -272,7 +272,7 @@ def download(
chunk_size: Optional[int] = None,
timeout: Optional[int] = DEFAULT_TIMEOUT,
num_max_attempts: Optional[int] = 1,
- ) -> Union[str, bytes]:
+ ) -> bytes:
Review comment:
I think this is still `Union[str, bytes]` because `filename` should be a str.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org