You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/03/14 23:44:57 UTC
[GitHub] zeppelin pull request #2136: [ZEPPELIN-2113] Paragraph border is not highlig...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2136
[ZEPPELIN-2113] Paragraph border is not highlighted when focused
### What is this PR for?
https://github.com/apache/zeppelin/pull/2054 [removes `paragraph-col` css class](https://github.com/apache/zeppelin/pull/2054/files#diff-fe483b8eb5467153a772f202838dfb18L115). As a result paragraph is not highlighted when focused.
This PR apply `paragraph-col` css class when it is not iframe mode.
### What type of PR is it?
Bug Fix
### Todos
* [x] - apply `paragraph-col` css class
### What is the Jira issue?
http://issues.apache.org/jira/browse/ZEPPELIN-2113
### How should this be tested?
Click any paragraph and see if paragraph border is highlighted
### Screenshots (if appropriate)
before
after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2113-followup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2136
----
commit 45c1717be73fafc7591564050d885bd8f6c46831
Author: Lee moon soo <mo...@apache.org>
Date: 2017-03-14T23:36:02Z
apply paragraph-col class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2136: [ZEPPELIN-2113] Paragraph border is not highlighted wh...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2136
@Leemoonsoo Thanks for fix! (It's because of me :sweat_smile: )
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2136: [ZEPPELIN-2113] Paragraph border is not highlig...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2136: [ZEPPELIN-2113] Paragraph border is not highlighted wh...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2136
@soralee No worries. Thanks for the review.
Merge to master and branch-0.7 if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---