You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/04/20 04:16:00 UTC
[jira] [Commented] (SOLR-15155) Let CloudHttp2SolrClient accept an
external Http2SolrClient Builder
[ https://issues.apache.org/jira/browse/SOLR-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325460#comment-17325460 ]
ASF subversion and git services commented on SOLR-15155:
--------------------------------------------------------
Commit 72a99483c93cbeed4b09ed6cbb94ad3111afafe4 in solr's branch refs/heads/main from Tomas Eduardo Fernandez Lobbe
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=72a9948 ]
SOLR-15155: Document how to set credentials in CloudHttp2SolrClient (#51)
> Let CloudHttp2SolrClient accept an external Http2SolrClient Builder
> -------------------------------------------------------------------
>
> Key: SOLR-15155
> URL: https://issues.apache.org/jira/browse/SOLR-15155
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomas Eduardo Fernandez Lobbe
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {{CloudHttp2SolrClient}} doesn't provide much of the options that {{Http2SolrClient}} does (timeouts, max connections per hosts, etc). Technically it accepts a fully built {{Http2SolrClient}}, however, in such case the client becomes "external", which means it won't be closed when the CloudClient is closed (one needs to maintain a reference and close explicitly after closing CloudClient).
> {{CloudHttp2SolrClient}} will use an empty/default {{Http2SolrClient.Builder}} to build it's internal client. I propose we allow providing a configured {{Http2SolrClient.Builder}} instead and let the {{CloudHttp2SolrClient}} just build from it. This would be optional of course, and backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org