Checkstyle oddity

[Josh Elser <jo...@gmail.com>]

I had a failure in the checkstyle rules, specifically the unusedimports 
module.

I had a case where Eclipse inserted the import for a class that was only 
referenced in javadocs. I see that we have the option enabled which 
should allow this in the checkstyle-plugin configuration, but this 
doesn't seem to be working as expected.

Has anyone else run into this? Is it an upstream checkstyle-plugin bug? 
I've worked around it by putting the full class name in the javadoc.

- Josh

Re: Checkstyle oddity

[Josh Elser <jo...@gmail.com>]

SaslConnectionParams (assuming I did it correctly) shouldn't be 
necessary for import elsewhere.

Good to know about @see.

Christopher wrote:
> Okay, interesting, it might not work with @see. However, that looks to me
> like it'd be fine, because the import is used elsewhere in the class.
>
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>
> On Tue, Feb 10, 2015 at 4:30 PM, Josh Elser<jo...@gmail.com>  wrote:
>
>> My thought might be that the module doesn't work right within the @see,
>> maybe. The below commit *should* work (as I understand things), but fails
>> the checkstyle violation.
>>
>> https://github.com/joshelser/accumulo/commit/
>> 3837db22a288747e068f9fde12618776f35cd107
>>
>> Be forewarned, the above branch is based on the pending delegation token
>> branch where I saw this.
>>
>>
>> Christopher wrote:
>>
>>> I know I tested this rule, and saw it work correctly. Can you send me a
>>> patch that reproduces the issue you saw?
>>>
>>>
>>> --
>>> Christopher L Tubbs II
>>> http://gravatar.com/ctubbsii
>>>
>>> On Mon, Feb 9, 2015 at 10:57 PM, Josh Elser<jo...@gmail.com>   wrote:
>>>
>>>   I had a failure in the checkstyle rules, specifically the unusedimports
>>>> module.
>>>>
>>>> I had a case where Eclipse inserted the import for a class that was only
>>>> referenced in javadocs. I see that we have the option enabled which
>>>> should
>>>> allow this in the checkstyle-plugin configuration, but this doesn't seem
>>>> to
>>>> be working as expected.
>>>>
>>>> Has anyone else run into this? Is it an upstream checkstyle-plugin bug?
>>>> I've worked around it by putting the full class name in the javadoc.
>>>>
>>>> - Josh
>>>>
>>>>
>

Re: Checkstyle oddity

[Christopher <ct...@apache.org>]

Okay, interesting, it might not work with @see. However, that looks to me
like it'd be fine, because the import is used elsewhere in the class.


--
Christopher L Tubbs II
http://gravatar.com/ctubbsii

On Tue, Feb 10, 2015 at 4:30 PM, Josh Elser <jo...@gmail.com> wrote:

> My thought might be that the module doesn't work right within the @see,
> maybe. The below commit *should* work (as I understand things), but fails
> the checkstyle violation.
>
> https://github.com/joshelser/accumulo/commit/
> 3837db22a288747e068f9fde12618776f35cd107
>
> Be forewarned, the above branch is based on the pending delegation token
> branch where I saw this.
>
>
> Christopher wrote:
>
>> I know I tested this rule, and saw it work correctly. Can you send me a
>> patch that reproduces the issue you saw?
>>
>>
>> --
>> Christopher L Tubbs II
>> http://gravatar.com/ctubbsii
>>
>> On Mon, Feb 9, 2015 at 10:57 PM, Josh Elser<jo...@gmail.com>  wrote:
>>
>>  I had a failure in the checkstyle rules, specifically the unusedimports
>>> module.
>>>
>>> I had a case where Eclipse inserted the import for a class that was only
>>> referenced in javadocs. I see that we have the option enabled which
>>> should
>>> allow this in the checkstyle-plugin configuration, but this doesn't seem
>>> to
>>> be working as expected.
>>>
>>> Has anyone else run into this? Is it an upstream checkstyle-plugin bug?
>>> I've worked around it by putting the full class name in the javadoc.
>>>
>>> - Josh
>>>
>>>
>>

Re: Checkstyle oddity

[Josh Elser <jo...@gmail.com>]

My thought might be that the module doesn't work right within the @see, 
maybe. The below commit *should* work (as I understand things), but 
fails the checkstyle violation.

https://github.com/joshelser/accumulo/commit/3837db22a288747e068f9fde12618776f35cd107

Be forewarned, the above branch is based on the pending delegation token 
branch where I saw this.

Christopher wrote:
> I know I tested this rule, and saw it work correctly. Can you send me a
> patch that reproduces the issue you saw?
>
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>
> On Mon, Feb 9, 2015 at 10:57 PM, Josh Elser<jo...@gmail.com>  wrote:
>
>> I had a failure in the checkstyle rules, specifically the unusedimports
>> module.
>>
>> I had a case where Eclipse inserted the import for a class that was only
>> referenced in javadocs. I see that we have the option enabled which should
>> allow this in the checkstyle-plugin configuration, but this doesn't seem to
>> be working as expected.
>>
>> Has anyone else run into this? Is it an upstream checkstyle-plugin bug?
>> I've worked around it by putting the full class name in the javadoc.
>>
>> - Josh
>>
>

Re: Checkstyle oddity

[Christopher <ct...@apache.org>]

I know I tested this rule, and saw it work correctly. Can you send me a
patch that reproduces the issue you saw?


--
Christopher L Tubbs II
http://gravatar.com/ctubbsii

On Mon, Feb 9, 2015 at 10:57 PM, Josh Elser <jo...@gmail.com> wrote:

> I had a failure in the checkstyle rules, specifically the unusedimports
> module.
>
> I had a case where Eclipse inserted the import for a class that was only
> referenced in javadocs. I see that we have the option enabled which should
> allow this in the checkstyle-plugin configuration, but this doesn't seem to
> be working as expected.
>
> Has anyone else run into this? Is it an upstream checkstyle-plugin bug?
> I've worked around it by putting the full class name in the javadoc.
>
> - Josh
>