You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "Jimexist (via GitHub)" <gi...@apache.org> on 2023/08/11 00:54:27 UTC

[GitHub] [thrift] Jimexist commented on a diff in pull request #2843: THRIFT-5653: Fix Java UUID typeid

Jimexist commented on code in PR #2843:
URL: https://github.com/apache/thrift/pull/2843#discussion_r1290806122


##########
lib/java/src/main/java/org/apache/thrift/protocol/TType.java:
##########
@@ -34,6 +34,9 @@ public final class TType {
   public static final byte MAP = 13;
   public static final byte SET = 14;
   public static final byte LIST = 15;
-  public static final byte ENUM = 16;
-  public static final byte UUID = 17;
+  public static final byte UUID = 16;
+
+  // This is not part of the TBinaryProtocol spec but Java specific
+  // implementation detail.

Review Comment:
   ```suggestion
     /** 
      * This is not part of the TBinaryProtocol spec but Java specific
      * implementation detail
      */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org