You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Armando <a....@student.vu.nl> on 2013/09/10 01:45:25 UTC
Review Request 14046: GIRAPH-755: Make ZooKeeper port list available to
input/output format
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14046/
-----------------------------------------------------------
Review request for giraph.
Repository: giraph-git
Description
-------
This patch is intended to refactor the way zookeeper list is kept in the configuration. In this manner the list is available also in other classes different from the services (BspService) which may benefit of zookeeper functionalities.
I introduce the change of semantic of this type:
conf.getZookeeperList() != null is equivalent to conf.isZookeeperExternal()
Diffs
-----
giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java aae01da
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 15ff861
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 604729a
giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 704fb9e
giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 454c934
giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 112b76d
giraph-core/src/main/java/org/apache/giraph/yarn/GiraphYarnClient.java 341db0e
Diff: https://reviews.apache.org/r/14046/diff/
Testing
-------
mvn verify with java 6 passed.
Thanks,
Armando
Re: Review Request 14046: GIRAPH-755: Make ZooKeeper port list available to
input/output format
Posted by Armando <a....@student.vu.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14046/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 11:11 a.m.)
Review request for giraph.
Changes
-------
updated the diff for the current trunk (on github).
Repository: giraph-git
Description
-------
This patch is intended to refactor the way zookeeper list is kept in the configuration. In this manner the list is available also in other classes different from the services (BspService) which may benefit of zookeeper functionalities.
I introduce the change of semantic of this type:
conf.getZookeeperList() != null is equivalent to conf.isZookeeperExternal()
Diffs (updated)
-----
giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java 34f4b51
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java f176bfe
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 6f32e46
giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 3939d49
giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java f043c61
giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java a92ddf8
giraph-core/src/main/java/org/apache/giraph/yarn/GiraphYarnClient.java ab6564e
Diff: https://reviews.apache.org/r/14046/diff/
Testing
-------
mvn verify with java 6 passed.
Thanks,
Armando
Re: Review Request 14046: GIRAPH-755: Make ZooKeeper port list available to
input/output format
Posted by Armando <a....@student.vu.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14046/
-----------------------------------------------------------
(Updated Sept. 15, 2013, 11:51 a.m.)
Review request for giraph.
Changes
-------
sorry, uploaded the previous patch in the wrong place
Repository: giraph-git
Description
-------
This patch is intended to refactor the way zookeeper list is kept in the configuration. In this manner the list is available also in other classes different from the services (BspService) which may benefit of zookeeper functionalities.
I introduce the change of semantic of this type:
conf.getZookeeperList() != null is equivalent to conf.isZookeeperExternal()
Diffs (updated)
-----
giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java aae01da
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 15ff861
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 604729a
giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 704fb9e
giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 454c934
giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 112b76d
giraph-core/src/main/java/org/apache/giraph/yarn/GiraphYarnClient.java 341db0e
Diff: https://reviews.apache.org/r/14046/diff/
Testing
-------
mvn verify with java 6 passed.
Thanks,
Armando
Re: Review Request 14046: GIRAPH-755: Make ZooKeeper port list available to
input/output format
Posted by Armando <a....@student.vu.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14046/
-----------------------------------------------------------
(Updated Sept. 14, 2013, 10:27 p.m.)
Review request for giraph.
Changes
-------
Updating the patch with error messaging when Edge or Vertex Input/Output format are missing.
Repository: giraph-git
Description
-------
This patch is intended to refactor the way zookeeper list is kept in the configuration. In this manner the list is available also in other classes different from the services (BspService) which may benefit of zookeeper functionalities.
I introduce the change of semantic of this type:
conf.getZookeeperList() != null is equivalent to conf.isZookeeperExternal()
Diffs (updated)
-----
giraph-rexster/src/main/java/org/apache/giraph/rexster/conf/GiraphRexsterConstants.java c4b4655
giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterEdgeInputFormat.java 4dee078
giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterEdgeOutputFormat.java PRE-CREATION
giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterVertexInputFormat.java da45b5b
giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterVertexOutputFormat.java PRE-CREATION
giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/RexsterLongDoubleFloatEdgeOutputFormat.java PRE-CREATION
giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/RexsterLongDoubleFloatVertexOutputFormat.java PRE-CREATION
giraph-rexster/src/main/java/org/apache/giraph/rexster/utils/RexsterUtils.java e669ca9
giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestAbstractRexsterInputFormat.java 09b27d3
giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestRexsterLongDoubleFloatInputFormat.java PRE-CREATION
giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestRexsterLongDoubleFloatOutputFormat.java PRE-CREATION
giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestRexsterLongDoubleFloatVertexInputFormat.java a68db67
Diff: https://reviews.apache.org/r/14046/diff/
Testing
-------
mvn verify with java 6 passed.
Thanks,
Armando
Re: Review Request 14046: GIRAPH-755: Make ZooKeeper port list available to
input/output format
Posted by Claudio Martella <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14046/#review26014
-----------------------------------------------------------
Looks good, I like this cleaner semantics of the ZK configuration, compared to != null.
- Claudio Martella
On Sept. 9, 2013, 11:45 p.m., Armando wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14046/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 11:45 p.m.)
>
>
> Review request for giraph.
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> This patch is intended to refactor the way zookeeper list is kept in the configuration. In this manner the list is available also in other classes different from the services (BspService) which may benefit of zookeeper functionalities.
>
> I introduce the change of semantic of this type:
> conf.getZookeeperList() != null is equivalent to conf.isZookeeperExternal()
>
>
> Diffs
> -----
>
> giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java aae01da
> giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 15ff861
> giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 604729a
> giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 704fb9e
> giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 454c934
> giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 112b76d
> giraph-core/src/main/java/org/apache/giraph/yarn/GiraphYarnClient.java 341db0e
>
> Diff: https://reviews.apache.org/r/14046/diff/
>
>
> Testing
> -------
>
> mvn verify with java 6 passed.
>
>
> Thanks,
>
> Armando
>
>