You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/10 06:20:59 UTC

[GitHub] [bookkeeper] fanjianye opened a new pull request #3037: fix BookieStats

fanjianye opened a new pull request #3037:
URL: https://github.com/apache/bookkeeper/pull/3037


   Descriptions of the changes in this PR:
   
   
   
   ### Motivation
   
   1. the code style in BookieStats is different to other Stats
   2. the BOOKIE_READ_ENTRY_BYTES metric in BookieStats is not correct 
   
   ### Changes
   
   1. fix the code style problem in BookieStats
   2. since the BOOKIE_READ_ENTRY_BYTES and the READ_BYTES metric both collect entry.readableBytes() in BookieImpl#readEntry()，it is better to keep the counter, not OpStatsLogger. OpStatsLogger is relatively expensive.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] TakaHiro0208 closed pull request #3037: fix metric error and format problem in BookieStats

Posted by GitBox <gi...@apache.org>.

TakaHiro0208 closed pull request #3037:
URL: https://github.com/apache/bookkeeper/pull/3037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org