You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Andrew Wheat (JIRA)" <ji...@apache.org> on 2012/08/29 10:30:07 UTC
[jira] [Created] (CAMEL-5546) Zookeper master election logic is too
tightly bound to the route policy logic
Andrew Wheat created CAMEL-5546:
-----------------------------------
Summary: Zookeper master election logic is too tightly bound to the route policy logic
Key: CAMEL-5546
URL: https://issues.apache.org/jira/browse/CAMEL-5546
Project: Camel
Issue Type: Improvement
Components: camel-zookeeper
Affects Versions: 2.10.0
Reporter: Andrew Wheat
Priority: Minor
The current structure of the ZooKeeperRoutePolicy does not allow the master election to be re-used.
Extracting the master election to a separate top-level class with a suitable, simple API;
{noformat}public boolean isMaster() { ... } {noformat}
would make re-using the election for things that are not a route easier.
The election constructor then takes the same parameters as the existing ZookeeperRoutePolicy, and the new ZooKeeperRoutePolicy would take an election instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5546) Zookeper master election logic is too
tightly bound to the route policy logic
Posted by "Andrew Wheat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Wheat updated CAMEL-5546:
--------------------------------
Attachment: CAMEL-5546.diff
Quite a large diff; I have the changes in several git commits (based on the github mirror of camel) that I can make public if that is a better or easier way of integrating the changes.
> Zookeper master election logic is too tightly bound to the route policy logic
> -----------------------------------------------------------------------------
>
> Key: CAMEL-5546
> URL: https://issues.apache.org/jira/browse/CAMEL-5546
> Project: Camel
> Issue Type: Improvement
> Components: camel-zookeeper
> Affects Versions: 2.10.0
> Reporter: Andrew Wheat
> Priority: Minor
> Attachments: CAMEL-5546.diff
>
>
> The current structure of the ZooKeeperRoutePolicy does not allow the master election to be re-used.
> Extracting the master election to a separate top-level class with a suitable, simple API;
> {noformat}public boolean isMaster() { ... } {noformat}
> would make re-using the election for things that are not a route easier.
> The election constructor then takes the same parameters as the existing ZookeeperRoutePolicy, and the new ZooKeeperRoutePolicy would take an election instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-5546) Zookeper master election logic is
too tightly bound to the route policy logic
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-5546.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.11.0
Applied patch into trunk with thanks to Andrew.
> Zookeper master election logic is too tightly bound to the route policy logic
> -----------------------------------------------------------------------------
>
> Key: CAMEL-5546
> URL: https://issues.apache.org/jira/browse/CAMEL-5546
> Project: Camel
> Issue Type: Improvement
> Components: camel-zookeeper
> Affects Versions: 2.10.0
> Reporter: Andrew Wheat
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.11.0
>
> Attachments: CAMEL-5546.diff
>
>
> The current structure of the ZooKeeperRoutePolicy does not allow the master election to be re-used.
> Extracting the master election to a separate top-level class with a suitable, simple API;
> {noformat}public boolean isMaster() { ... } {noformat}
> would make re-using the election for things that are not a route easier.
> The election constructor then takes the same parameters as the existing ZookeeperRoutePolicy, and the new ZooKeeperRoutePolicy would take an election instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-5546) Zookeper master election logic is
too tightly bound to the route policy logic
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-5546:
-----------------------------------
Assignee: Willem Jiang
> Zookeper master election logic is too tightly bound to the route policy logic
> -----------------------------------------------------------------------------
>
> Key: CAMEL-5546
> URL: https://issues.apache.org/jira/browse/CAMEL-5546
> Project: Camel
> Issue Type: Improvement
> Components: camel-zookeeper
> Affects Versions: 2.10.0
> Reporter: Andrew Wheat
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: CAMEL-5546.diff
>
>
> The current structure of the ZooKeeperRoutePolicy does not allow the master election to be re-used.
> Extracting the master election to a separate top-level class with a suitable, simple API;
> {noformat}public boolean isMaster() { ... } {noformat}
> would make re-using the election for things that are not a route easier.
> The election constructor then takes the same parameters as the existing ZookeeperRoutePolicy, and the new ZooKeeperRoutePolicy would take an election instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5546) Zookeper master election logic is too
tightly bound to the route policy logic
Posted by "Andrew Wheat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Wheat updated CAMEL-5546:
--------------------------------
Patch Info: Patch Available
> Zookeper master election logic is too tightly bound to the route policy logic
> -----------------------------------------------------------------------------
>
> Key: CAMEL-5546
> URL: https://issues.apache.org/jira/browse/CAMEL-5546
> Project: Camel
> Issue Type: Improvement
> Components: camel-zookeeper
> Affects Versions: 2.10.0
> Reporter: Andrew Wheat
> Priority: Minor
> Attachments: CAMEL-5546.diff
>
>
> The current structure of the ZooKeeperRoutePolicy does not allow the master election to be re-used.
> Extracting the master election to a separate top-level class with a suitable, simple API;
> {noformat}public boolean isMaster() { ... } {noformat}
> would make re-using the election for things that are not a route easier.
> The election constructor then takes the same parameters as the existing ZookeeperRoutePolicy, and the new ZooKeeperRoutePolicy would take an election instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira