You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Jim Plush (JIRA)" <ji...@apache.org> on 2011/06/25 21:05:47 UTC

[jira] [Commented] (HADOOP-7135) Commit 949660 broke FileUtil.copyMerge

    [ https://issues.apache.org/jira/browse/HADOOP-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054950#comment-13054950 ] 

Jim Plush commented on HADOOP-7135:
-----------------------------------

the link above is a 404, any chance of updating it?

> Commit 949660 broke FileUtil.copyMerge
> --------------------------------------
>
>                 Key: HADOOP-7135
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7135
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Jeffrey Gerard
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Looking at http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.21/src/java/org/apache/hadoop/fs/FileUtil.java?r1=949659&r2=949660&
> it seems this commit broke FileUtil.copyMerge by omitting NOT operator.  copyMerge only makes sense if srcDir is a directory.
> Should be
>     if (!srcFS.getFileStatus(srcDir).isDirectory())
>        return false;

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira