You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/11 15:38:57 UTC

[GitHub] [spark] mridulm commented on a change in pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

mridulm commented on a change in pull request #28939:
URL: https://github.com/apache/spark/pull/28939#discussion_r468677043



##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -220,6 +220,21 @@ private[spark] class Executor(
 
   heartbeater.start()
 
+  private val appStartTime = conf.getLong("spark.app.startTime", 0)
+
+  // Jars and files specified by spark.jars and spark.files.

Review comment:
       nit: Given both are identical code blocks, with only the key being different - refactor it ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org